Repository navigation
refactor(afternote): 에디터 곡·영상 변환 규칙을 공통화한다 (#2166) - #2167
Merged
Merged
Conversation
OnlyReadOneBook
added this pull request to stack #2182
September 27, 2026 04:55
This was referenced Sep 27, 2026
Sadturtleman
approved these changes
Oct 4, 2026
Sadturtleman
left a comment
Collaborator
There was a problem hiding this comment.
곡·영상 변환을 private 함수로 모으면서 빈 값 처리와 곡 순서가 그대로 유지되는 것을 확인했습니다. 승인합니다.
koongmai
approved these changes
Oct 4, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2166
Refs #2163
생성 요청과 현재값 스냅샷에 반복되던 곡 객체 조립, 영상 URL·썸네일 정규화를 폼 매퍼의 private 함수로 모읍니다. 유효한 영상 URL과 빈 썸네일의 null 처리, 곡 값과 순서, DTO·PATCH 동작은 유지합니다.
직접 base는 #2164의
refactor/2163-category-snapshot입니다. 이 변환 구조를 #1837 이후 에디터 스택이 그대로 소비합니다. 최신 develop의 영상 세 상태와 스냅샷 v6를 포함합니다.검증
HEAD
f67d10e59b6802036f6314f38fe1e78fab0d7456에서 presentation 340개 테스트가 통과했습니다(실패·오류·건너뜀 0). presentation ktlint, 실제 base 대비 전체 diff의 모듈 소유권 검사와git diff --check를 통과했습니다.🧪 CI Test Plan
{ "androidTest": { "mode": "none", "reason": "같은 파일 안의 순수 변환 코드 추출이며 UI·Android API 변경 없이 기존 생성 및 PATCH 단위 테스트로 검증합니다.", "tests": [] } }