Skip to content

maintenance(platform): 쓰지 않는 hilt-navigation-compose 의존과 feature 컨벤션 플러그인을 걷는다 (#2247) #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OnlyReadOneBook merged 1 commit into from
Oct 5, 2026
Merged

maintenance(platform): 쓰지 않는 hilt-navigation-compose 의존과 feature 컨벤션 플러그인을 걷는다 (#2247) #2257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/ktlint-coverage.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
// 「.kt 를 가진 모듈」이 아니라 **등록된 모듈 전부**다.
//
// ktlint 는 두 경로로 붙는다 — 모듈이 직접 적용하거나, ktlint 를 적용하는 컨벤션 플러그인을
// 타거나. 컨벤션은 서로를 apply 하며 사슬을 이루므로(android.feature → android.library.compose →
// android.library → android.lint) 여기서 그 사슬의 전이 폐포를 계산한다. 컨벤션이 새로 생겨도
// 타거나. 컨벤션은 서로를 apply 하며 사슬을 이루므로(android.library.compose → android.library →
// android.lint) 여기서 그 사슬의 전이 폐포를 계산한다. 컨벤션이 새로 생겨도
// 목록을 손으로 고칠 필요가 없다.

import fs from "node:fs/promises";
Expand Down
1 change: 0 additions & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ baselineProfile {

dependencies {
implementation(libs.coil.compose)
implementation(libs.androidx.hilt.navigation.compose)
implementation(libs.core.splashscreen)

// App Startup — 기동 초기화는 app 매니페스트에 등록한 Initializer 로 실행한다.
Expand Down
4 changes: 0 additions & 4 deletions build-logic/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ gradlePlugin {
id = "afternote.android.navigation"
implementationClass = "AndroidNavigationConventionPlugin"
}
register("androidFeature") {
id = "afternote.android.feature"
implementationClass = "AndroidFeatureConventionPlugin"
}
register("androidData") {
id = "afternote.android.data"
implementationClass = "AndroidDataConventionPlugin"
Expand Down
24 changes: 0 additions & 24 deletions build-logic/src/main/kotlin/AndroidFeatureConventionPlugin.kt
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion feature/afternote/presentation/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ dependencies {
implementation(libs.coil.network.okhttp)
implementation(libs.coil.compose)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.hilt.navigation.compose)
implementation(libs.hilt.navigation)
implementation(libs.androidx.lifecycle.viewmodel.ktx)
implementation(libs.androidx.lifecycle.runtime.compose)
Expand Down
1 change: 0 additions & 1 deletion feature/receiver/presentation/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ dependencies {
implementation(projects.core.common)
implementation(projects.core.ui)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.hilt.navigation.compose)
implementation(libs.hilt.navigation)
implementation(libs.androidx.lifecycle.viewmodel.ktx)
implementation(libs.androidx.lifecycle.runtime.compose)
Expand Down
1 change: 0 additions & 1 deletion feature/setting/presentation/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ dependencies {
implementation(projects.core.domain)
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(libs.androidx.hilt.navigation.compose)
implementation(libs.androidx.compose.runtime)
implementation(libs.androidx.biometric)
implementation(libs.androidx.credentials)
Expand Down
1 change: 0 additions & 1 deletion konsist/src/test/kotlin/com/afternote/konsist/ExplicitApiModulePolicyKonsistTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ class ExplicitApiModulePolicyKonsistTest {
"afternote.android.data",
"afternote.android.datastore",
"afternote.android.domain",
"afternote.android.feature",
"afternote.android.library",
"afternote.android.library.compose",
"afternote.jvm.domain",
Expand Down
Loading