Repository navigation
docs(changelog): four of the eight Databricks product tag keys are shared with Glue and Snowflake - #842
Merged
Conversation
…ared with Glue and Snowflake The 0.28.0 entry said all eight product tag keys are the ones AWS Glue and Snowflake already use. Only fluid_domain, fluid_layer, fluid_product_type and fluid_version are (iac/providers/aws.py and the Horizon comment lines in iac/providers/snowflake.py); fluid_product_id, fluid_product_name, fluid_product_version and fluid_owner_team are new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 0.28.0 entry "A Databricks data product looks like a native one in Unity Catalog" says all eight product tag keys are "the keys AWS Glue and Snowflake already use". Only four are:
fluid_domain,fluid_layer,fluid_product_typeandfluid_version. They come fromiac/providers/aws.py's Glue table parameters and the Horizon comment lines iniac/providers/snowflake.py.fluid_product_id,fluid_product_name,fluid_product_versionandfluid_owner_teamare new with #831. The entry now says so.A review of the forge_docs Databricks page (Agenticstiger/forge_docs#202) found this. The page already uses the corrected wording.
The v0.28.0 GitHub Release notes were taken from this section at tag time and still carry the old sentence. Editing them is a separate step.
Type of Change
Documentation
Testing
git grepof the eight keys influid_build/iac/providers/aws.pyandsnowflake.pyon main: only the four named above.awkextractor still reads the[0.28.0]section (224 non-empty lines), and[Unreleased]is still empty.CHANGELOG.md: clean.tools/product_guardrail/check.py: clean.