Repository navigation
feat(services): export current view safely - #645
Open
woahwhattheheck wants to merge 7 commits into
Open
woahwhattheheck wants to merge 7 commits into
woahwhattheheck wants to merge 7 commits into
Conversation
12 tasks
Author
|
/claim #631 Existing issue-level claim: #631 (comment) I, @woahwhattheheck, affirmatively claim original-contributor credit for PR #645 and request evaluation for any applicable GrantFox OSS / Official Campaign (FWC26) reward and payment if accepted. Current carrier head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #631.
Summary
Coverage included
Unit coverage represents current-view order, CSV escaping, formula neutralization, empty CSV, JSON round-trip and download metadata. Component coverage represents CSV download, empty-view JSON download and typed download failure. The current page-level regression also verifies that the service-ID filter removes nonmatching rows before the export receives the current view.
Verification and limits
Published source head:
2744abed6bce6255b572eba7922c456ada7d31f3.Sponsor base:
0d47dba0eb086756a906fc66670f98b2374fce04.Current carrier: 7 commits, 6 changed files, +424/-2.
Current source readback confirms
ServiceExportActionsreceivessortedServices, where filtering is applied before sorting, and the page-level test exercises the active service-ID filter. No local lint, test, build, browser execution or current-head hosted CI pass is claimed in this metadata recovery. Included tests are coverage, not an assertion that the issue's execution gates have passed.This exports the currently supplied page view; it does not add server-side or whole-dataset export, XLSX, dependency-lock repair or unrelated dashboard changes.