advising on refactor here, and first PR in line was a refactoring of the tests, so was taking a look at at the tests. noticed that some of these tests don't have any assertions at all in them, and so they don't really test anything (or, rather, they test that the code runs, but nothing specific about it and their failure is uninformative).
e.g. this one:
|
def test_demo_pipeline_realds( |
either these tests should gain meaningful assertions or be removed - not clear to me what the tests are testing exactly in most of the cases, so can't advise, but tests without assertions are wasted time
advising on refactor here, and first PR in line was a refactoring of the tests, so was taking a look at at the tests. noticed that some of these tests don't have any assertions at all in them, and so they don't really test anything (or, rather, they test that the code runs, but nothing specific about it and their failure is uninformative).
e.g. this one:
indeca/tests/integration/test_pipeline.py
Line 248 in ee1767c
either these tests should gain meaningful assertions or be removed - not clear to me what the tests are testing exactly in most of the cases, so can't advise, but tests without assertions are wasted time