Test framework, stage 1: every test ready to share a binary

.github/actions/setup-build/action.yaml

@@ -51,7 +51,7 @@ runs:
           libpipewire-0.3-dev libpulse-dev libsndio-dev libtext-unidecode-perl \
           libthai-dev libtool libudev-dev libunwind-dev liburing-dev libwayland-dev \
           libx11-dev libxcursor-dev libxext-dev libxfixes-dev libxft-dev libxi-dev libxinerama-dev \
-          libxkbcommon-dev libxrandr-dev libxss-dev libxtst-dev linux-libc-dev mold \
+          libxkbcommon-dev libxrandr-dev libxss-dev libxtst-dev linux-libc-dev \
           nasm ninja-build pkgconf rpm tar tex-common texinfo unzip zip
 
         sudo locale-gen en_US.UTF-8
@@ -66,6 +66,28 @@ runs:
         sudo rm -rf /usr/local/.ghcup
         df -h
 
+    # mold from its release rather than the image's 2.40: before 2.42.1 it
+    # can leave a function with no unwind entry the unwinder finds, so that
+    # an exception thrown through it ends the program (rui314/mold#1648).
+    # Pinned by digest, under /usr/local, which the path puts first.
+    - name: Linux mold install
+      if: runner.os == 'Linux'
+      shell: bash
+      run: |
+        version=2.42.1
+        case "$(uname -m)" in
+          x86_64) arch=x86_64 sha256=6ff270c9bf07d2bec5c98aa324eb7c4daf6a1a4d815c05ff1708049616047855 ;;
+          aarch64) arch=aarch64 sha256=16b025652d3d7456689e6025a77e1903bb2a15e7630877c26cc133f5df95b9c6 ;;
+          *) echo "::error::No mold release pinned for $(uname -m)"; exit 1 ;;
+        esac
+        archive="$RUNNER_TEMP/mold.tar.gz"
+        curl -fsSL -o "$archive" \
+          "https://github.com/rui314/mold/releases/download/v$version/mold-$version-$arch-linux.tar.gz"
+        echo "$sha256  $archive" | sha256sum -c -
+        sudo tar -xzf "$archive" -C /usr/local --strip-components=1 --no-same-owner
+        rm "$archive"
+        mold --version
+
     - name: macOS Homebrew dependency install
       if: runner.os == 'macOS'
       shell: bash

indra/alscript/tests/alincludesearch_test.cpp

@@ -428,23 +428,26 @@ namespace tut
     // the code still, which keeps it for a require found nowhere, for each
     // name it took; an alias's it read through the `.luaurc`, which is gone,
     // and is kept as it found it.
-    struct RequireCase
+    namespace
     {
-        // What it shows, and whose case it is.
-        const char* what;
-        // The file asking, under the tree; "object" for a script in an
-        // object, which with world includes off reads nothing of the world.
-        const char* from;
-        const char* name;
-        // What it finds, under the tree, or nothing: what the search found
-        // before the navigator, and what it finds now, as LAD9 has it.
-        const char* before;
-        const char* chosen;
-        // Whose rule LAD9 picks, where the references or we disagree: and
-        // what Luau's navigator answers, where it differs from the choice.
-        const char* rule;
-        const char* luau;
-    };
+        struct RequireCase
+        {
+            // What it shows, and whose case it is.
+            const char* what;
+            // The file asking, under the tree; "object" for a script in an
+            // object, which with world includes off reads nothing of the world.
+            const char* from;
+            const char* name;
+            // What it finds, under the tree, or nothing: what the search found
+            // before the navigator, and what it finds now, as LAD9 has it.
+            const char* before;
+            const char* chosen;
+            // Whose rule LAD9 picks, where the references or we disagree: and
+            // what Luau's navigator answers, where it differs from the choice.
+            const char* rule;
+            const char* luau;
+        };
+    } // anonymous namespace
 
     template<> template<>
     void alincludesearch_object::test<7>()

indra/alscript/tests/allslservice_test.cpp

@@ -742,7 +742,9 @@ namespace tut
             all << in.rdbuf();
             text = all.str();
         }
-        const std::string path = (std::filesystem::temp_directory_path() / "alscript-test-builtins-newer.txt").string();
+        // a name of its own, so two runs at once never write one file
+        const std::string path =
+            (std::filesystem::temp_directory_path() / ("alscript-test-builtins-newer-" + LLUUID::generateNewID().asString() + ".txt")).string();
         {
             llofstream out(path, std::ios::out | std::ios::binary | std::ios::trunc);
             out << text << "integer llBrandNewThing( integer Value )\n";

indra/alscript/tests/alluauconfig_test.cpp

@@ -28,6 +28,8 @@
 #include "../luau/alluauconfigscript.h"
 #include "../lint/alscriptlintpass.h"
 
+#include "lluuid.h"
+
 #include "../test/lltut.h"
 
 #include <chrono>
@@ -298,12 +300,16 @@ namespace tut
         ensure("an __index that would loop is never asked",
                ALLuauConfigScript::asLuaurc("return setmetatable({}, { __index = function() while true do end end })", json, error) && json == "{}");
 
-        const auto started = std::chrono::steady_clock::now();
-        ensure_equals("a loop that never ends, stopped", (ALLuauConfigScript::asLuaurc("while true do end", json, error), error),
+        // A run stopped by the deadline is kept a while, by its text: a text
+        // of this run's own is run, not answered from what another test, or
+        // this one before, asked.
+        const std::string forever = "while true do end -- " + LLUUID::generateNewID().asString();
+        const auto        started = std::chrono::steady_clock::now();
+        ensure_equals("a loop that never ends, stopped", (ALLuauConfigScript::asLuaurc(forever, json, error), error),
                       std::string("configuration execution timed out"));
         const F64 took = std::chrono::duration<F64>(std::chrono::steady_clock::now() - started).count();
         ensure(llformat("stopped at its time, not long after: %.2f s", took), took >= ALLuauConfigScript::MOST_SECONDS && took < ALLuauConfigScript::MOST_SECONDS + 2.0);
-        ensure("asked again at once, kept for a while: no second wait", (ALLuauConfigScript::asLuaurc("while true do end", json, error),
+        ensure("asked again at once, kept for a while: no second wait", (ALLuauConfigScript::asLuaurc(forever, json, error),
                                                                          std::chrono::duration<F64>(std::chrono::steady_clock::now() - started).count() < took + 0.1));
         // table.move's copy is a loop in C the deadline does not reach, and
         // nils moved into a table that holds none take no memory: held to so

indra/alscript/tests/alpreprocessor_test.cpp

@@ -194,6 +194,16 @@ namespace tut
             return ALPreprocessor::run(ended(source, ending), o);
         }
 
+        // The grid's builtins, which the optimizer and const folding read. A
+        // test that needs them asks for them itself: Tailslide keeps them for
+        // the process once loaded, so whichever asks first loads them.
+        static void ensureGridBuiltins()
+        {
+            ALLSLService service;
+            std::string  error;
+            ensure("builtins: " + error, service.loadBuiltins(std::string(AL_LSL_DEFINITIONS_DIR) + "/builtins.txt", error));
+        }
+
         // The same but the notes of a require nothing reads, which a script
         // made to try something else may leave about (test 50 tries them).
         static std::string faults(const ALPreprocessor::Result& r)
@@ -660,11 +670,7 @@ namespace tut
     void alpreprocessor_object::test<13>()
     {
         set_test_name("the optimizer runs over the expanded text, and its notes come back to the source");
-        {
-            ALLSLService service;
-            std::string  error;
-            ensure("builtins: " + error, service.loadBuiltins(std::string(AL_LSL_DEFINITIONS_DIR) + "/builtins.txt", error));
-        }
+        ensureGridBuiltins();
         add("consts.lsl", "#define CHANNEL 7\ninteger unused = 1;\n");
         ALPreprocessor::Options o = options();
         o.optimize                = true;
@@ -1192,11 +1198,7 @@ namespace tut
     void alpreprocessor_object::test<28>()
     {
         set_test_name("the optimizer's run, weighed, says what it saved in code: the whole, and each note what its lines came to less");
-        {
-            ALLSLService service;
-            std::string  error;
-            ensure("builtins: " + error, service.loadBuiltins(std::string(AL_LSL_DEFINITIONS_DIR) + "/builtins.txt", error));
-        }
+        ensureGridBuiltins();
         const std::string source = "integer unused(integer n)\n"
                                    "{\n"
                                    "    return n * 3;\n"
@@ -1249,11 +1251,7 @@ namespace tut
     void alpreprocessor_object::test<29>()
     {
         set_test_name("a script that does not compile is not the preprocessor's error: the optimizer stands aside with a note where the first error is");
-        {
-            ALLSLService service;
-            std::string  error;
-            ensure("builtins: " + error, service.loadBuiltins(std::string(AL_LSL_DEFINITIONS_DIR) + "/builtins.txt", error));
-        }
+        ensureGridBuiltins();
         // Nexii's library, whose ObjectLinksetSittingAvatars has a parameter
         // without its type, included as a save would include it.
         llifstream        in(std::string(AL_ALSCRIPT_TEST_DIR) + "/preprocessor/include/linkset.lsl", std::ios::binary);
@@ -1514,6 +1512,7 @@ namespace tut
     void alpreprocessor_object::test<39>()
     {
         set_test_name("a function marked inline in any of the ways a mark is written, at the top of the script, and the marks taken off with the extensions off");
+        ensureGridBuiltins();
         ALPreprocessor::Options o = options();
         o.extensions              = true;
         ALPreprocessor::Result r  = ALPreprocessor::run("integer f(integer a) inline { return a; }\n"
@@ -1554,6 +1553,7 @@ namespace tut
     void alpreprocessor_object::test<40>()
     {
         set_test_name("const before a type is taken off, and each name it declares said where it is, a function's as a function");
+        ensureGridBuiltins();
         const auto at = [](const ALPreprocessor::Result& r, size_t i, const std::string& name, S32 line, S32 column, bool function) {
             return i < r.consts.size() && r.consts[i].name == name && r.consts[i].line == line && r.consts[i].column == column &&
                    r.consts[i].function == function;
@@ -1838,7 +1838,7 @@ namespace tut
     // How often each module ran, as a module says it through `counted`,
     // a builtin of the VM, as SLua's are: a module's own globals are its
     // own, and what it sets is not the script's.
-    std::map<std::string, int> gRuns;
+    static std::map<std::string, int> gRuns;
 
     template<> template<>
     void alpreprocessor_object::test<48>()

indra/cmake/00-Common.cmake

@@ -300,6 +300,27 @@ if(LINUX)
   endif()
 endif()
 
+# No hot/cold splitting where GCC links with a mold older than 2.42.1. GCC
+# moves a function's unlikely blocks into a part of their own ("[clone
+# .cold]"), and where they all optimise away it still emits the part, empty,
+# with an unwind entry covering no bytes at the address of whatever follows
+# it. Those mold versions (rui314/mold#1648) put that entry in .eh_frame_hdr's
+# search table beside the real function's, in an order their unstable sort
+# leaves to chance; where the empty one comes last the unwinder finds no
+# entry for the function, and an exception thrown through it ends the program
+# in std::terminate whatever would have caught it. Without splitting there
+# are no such parts. The link option is for LTO, which generates the code
+# there. The vcpkg ports keep their empty parts: only a mold that leaves them
+# out of the table mends those.
+if(
+  COMPILER_IS_GCC
+  AND CMAKE_CXX_COMPILER_LINKER_ID STREQUAL "MOLD"
+  AND CMAKE_CXX_COMPILER_LINKER_VERSION VERSION_LESS 2.42.1
+)
+  target_compile_options(al_flags INTERFACE -fno-reorder-blocks-and-partition)
+  target_link_options(al_flags INTERFACE -fno-reorder-blocks-and-partition)
+endif()
+
 # Toolchain conformance and miscellany.
 if(WINDOWS)
   target_compile_options(

indra/llcharacter/CMakeLists.txt

@@ -63,10 +63,9 @@ target_link_libraries(
 target_precompile_headers(llcharacter REUSE_FROM llprecompiled)
 
 if(AL_BUILD_TESTS)
-  al_add_test(lljoint PROJECT llcharacter SOURCES lljoint.cpp LIBRARIES llcommon llmath)
-
   foreach(
     test
+    lljoint
     llpose
     llcharacter
     llmotioncontroller

indra/llcharacter/tests/llbvhloader_test.cpp

@@ -318,6 +318,8 @@ namespace
 }
 
 namespace tut
+{
+namespace
 {
     struct llbvhloader_data
     {
@@ -410,6 +412,7 @@ namespace tut
     typedef test_group<llbvhloader_data> llbvhloader_test;
     typedef llbvhloader_test::object llbvhloader_object;
     tut::llbvhloader_test llbvhloader_testcase("LLBVHLoader");
+}
 
     template<> template<>
     void llbvhloader_object::test<1>()

indra/llcharacter/tests/llcharacter_test.cpp

@@ -106,6 +106,8 @@ namespace
 }
 
 namespace tut
+{
+namespace
 {
     struct llcharacter_data
     {
@@ -162,6 +164,7 @@ namespace tut
     typedef test_group<llcharacter_data> llcharacter_test;
     typedef llcharacter_test::object llcharacter_object;
     tut::llcharacter_test llcharacter_testcase("LLCharacter");
+}
 
     template<> template<>
     void llcharacter_object::test<1>()

indra/llcharacter/tests/lljoint_test.cpp

@@ -36,13 +36,16 @@
 
 
 namespace tut
+{
+namespace
 {
     struct lljoint_data
     {
     };
     typedef test_group<lljoint_data> lljoint_test;
     typedef lljoint_test::object lljoint_object;
     tut::lljoint_test lljoint_testcase("LLJoint");
+}
 
     template<> template<>
     void lljoint_object::test<1>()

indra/llcharacter/tests/llkeyframemotion_test.cpp

@@ -487,6 +487,8 @@ namespace
 }
 
 namespace tut
+{
+namespace
 {
     struct llkeyframemotion_data
     {
@@ -521,6 +523,7 @@ namespace tut
     typedef test_group<llkeyframemotion_data> llkeyframemotion_test;
     typedef llkeyframemotion_test::object llkeyframemotion_object;
     tut::llkeyframemotion_test llkeyframemotion_testcase("LLKeyframeMotion");
+}
 
     template<> template<>
     void llkeyframemotion_object::test<1>()

indra/llcharacter/tests/llmotioncontroller_test.cpp

@@ -39,13 +39,16 @@ namespace
 }
 
 namespace tut
+{
+namespace
 {
     struct llmotioncontroller_data
     {
     };
     typedef test_group<llmotioncontroller_data> llmotioncontroller_test;
     typedef llmotioncontroller_test::object llmotioncontroller_object;
     tut::llmotioncontroller_test llmotioncontroller_testcase("LLMotionController");
+}
 
     typedef LLMotionController::QuantumStep QuantumStep;
 

indra/llcharacter/tests/llmultigesture_test.cpp

@@ -117,13 +117,16 @@ namespace
 }
 
 namespace tut
+{
+namespace
 {
     struct llmultigesture_data
     {
     };
     typedef test_group<llmultigesture_data> llmultigesture_test;
     typedef llmultigesture_test::object llmultigesture_object;
     tut::llmultigesture_test llmultigesture_testcase("LLMultiGesture");
+}
 
     template<> template<>
     void llmultigesture_object::test<1>()