Skip to content

Water's default probe keeps its irradiance on AMD: one tap for probe 0 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyeMutt merged 1 commit into from
Oct 23, 2026
Merged

Water's default probe keeps its irradiance on AMD: one tap for probe 0 #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions indra/newview/app_settings/shaders/class3/deferred/reflectionProbeF.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,30 +746,16 @@ void sampleProbeTaps(vec3 pos, ProbeTaps t, inout vec3 ambenv, inout vec3 glosse
neighbor = 0;
}
}

if (automatic && count < REF_SAMPLE_COUNT)
{ // probe at index 0 is a special probe for smoothing out automatic probes
probeTap(0, pos, probeBoxPos(0, pos), t, s);
++count;
}
#else
// Water takes probe 0 below.
if (!t.water)
{
probeTap(0, pos, probeBoxPos(0, pos), t, s);
++count;
}
#endif

if (t.water)
// Probe 0 is a special probe for smoothing out automatic probes, and water always includes it, where the list has
// room, mixing it in as an automatic probe. One tap serves both: given a tap of its own under water's condition,
// AMD's driver read the probe's irradiance as zero across a wave whose first pixel's list was full.
if ((automatic || t.water) && count < REF_SAMPLE_COUNT)
{
// always include void probe on water
automatic = true;
if (count < REF_SAMPLE_COUNT)
{
probeTap(0, pos, probeBoxPos(0, pos), t, s);
}
probeTap(0, pos, probeBoxPos(0, pos), t, s);
}
automatic = automatic || t.water;

if (t.ambient)
{
Expand Down
Loading