Skip to content

Feat/connect hero to app navigation - #14

Merged
Alex350-coder merged 7 commits into
mainfrom
feat/connect-hero-to-app-navigation
Sep 9, 2026
Merged

Alex350-coder merged 7 commits into
mainfrom
feat/connect-hero-to-app-navigation

Conversation

@Alex350-coder

Copy link
Copy Markdown
Owner

No description provided.

Alex350-coder and others added 7 commits September 8, 2026 14:19
… (BUG #12)

useProjects() called apiRequestPaginated("/projects") with no pageSize,
so the server defaulted to DEFAULT_PAGE_SIZE=25 (repository.types.ts).
The hook then discarded the response's pagination `meta` entirely, and
ProjectList has no "load more"/pager UI -- so an account with more than
25 projects silently lost access to the 26th+ project from the Projects
page. No error, no count, no indicator that more existed.

Reproduced live: created 26 test projects via the API (27 total),
reloaded /app, and confirmed only 25 rendered with zero way to reach
the rest through the UI.

Fixed by requesting the server's hard cap (MAX_PAGE_SIZE=100) instead
of relying on the default. This resolves the reported symptom for any
realistic project count; a true paginated/infinite-scroll UI for
counts beyond 100 is tracked separately as the "add missing
pagination/caching" work already scoped in Plan.md's hardening phase.
The same apiRequestPaginated-with-discarded-meta pattern also appears
in use-runs.ts, use-evidence.ts, use-reports.ts, and
use-project-members.ts; none were reproduced as broken via the browser
in this pass, so they're flagged for the same follow-up rather than
changed speculatively here.

Verified live: created 26 test projects (27 total), confirmed all 27
now render after the fix, then deleted the 26 test projects via the
API to restore the account to its prior state (Debug Test only).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…bling)

use-runs.ts, use-evidence.ts, use-reports.ts, and use-project-members.ts
all called apiRequestPaginated without a pageSize param, so the server
silently truncated results at DEFAULT_PAGE_SIZE=25. None of the
corresponding UIs (RunsList, EvidenceGrid, reports list, MembersPanel)
have pager/load-more controls, so any project with more than 25 runs,
evidence files, reports, or members would silently lose access to the
rest with zero indication -- the exact same root cause already fixed
in use-projects.ts under BUG #12.

Applied the identical fix: request the server's hard cap
(?pageSize=100) instead of relying on the default. Updated each
hook's existing test to assert the corrected URL and added coverage
where a query param already existed (evidence's nodeId case).

Full client suite verified green: 63 files / 190 tests passing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
BackgroundLayer/useParticleField had no Hero-specific coupling beyond
an optional focusRef prop, so move them from features/hero/background
to components/effects verbatim. This lets /login and /register reuse
the same animated background without duplicating the canvas logic.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The brand mark and 'Request access'/'Explore the graph engine' CTAs
in the marketing Hero rendered but had no href/onClick, leaving
first-time visitors with no way to reach /register, /login, or /app.

- Export buttonVariants from ui/button.tsx so a next/link can be
  styled as a button without nesting <Link> inside <Button>.
- Navbar/CTAGroup take an isAuthenticated prop and point at /register
  ('Request access') or /app ('Go to app') accordingly; brand mark
  links to '/'; 'Explore the graph engine' anchor-scrolls to the
  in-page graph demo instead of doing nothing.
- app/page.tsx becomes an async Server Component that checks for the
  presence of the httpOnly refresh-token cookie (the same coarse
  presence-check pattern proxy.ts already uses to gate /app) and
  passes hasSession down, so the CTA state is correct on first paint
  with no client-side fetch flash. This is a UX signal only — a stale
  cookie can't bypass auth, since WorkspaceShell's useBootstrapSession
  still enforces real authorization once a user reaches /app.

Covered by new Navbar.test.tsx / CTAGroup.test.tsx.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
/login and /register were flat, unstyled pages with no relationship
to the marketing Hero a visitor just came from. Mount the shared
BackgroundLayer behind each form, add a branded header (Radar icon +
wordmark linking back to '/'), and wrap the form in a bordered/glow
card using existing design tokens. LoginForm/RegisterForm/AuthField
internals are untouched — this is wrapper-level only.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
WorkspaceShell's header used plain text for the brand link while the
Hero used a Radar icon + wordmark. Add the same icon so the brand
mark is visually consistent whether a user is on the marketing site
or inside the authenticated app.

Also commit the AGENTS.md/CLAUDE.md pair that 'next dev' regenerates
on every start, per its own note that committing keeps the tree clean.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Covers vision, stack, folder layout, and a concrete getting-started
sequence (docker-compose -> server -> client) using the env vars each
package already documents in its own .env.example, plus pointers into
.claude/ for the deeper architecture/security/roadmap docs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Alex350-coder
Alex350-coder merged commit a5a63aa into main Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant