Skip to content

[PWGDQ] fix match type assignment in ML training data producer - #17535

Open
aferrero2707 wants to merge 2 commits into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-matching-training-producer-fix-match-type-assignment
Open

[PWGDQ] fix match type assignment in ML training data producer#17535
aferrero2707 wants to merge 2 commits into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-matching-training-producer-fix-match-type-assignment

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor

The match type assigned to candidate MFT-MCH matches in the ML training data producer task was wrongly set to "fake" in cases where the MCH track is pairable but the corresponding MFT track does not have an associated MC particle. In such cases the match type is now correrctly assigned as " wrong".

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 5 disabled

The match type assigned to candidate MFT-MCH matches in the ML training
data producer task was wrongly set to "fake" in cases where the MCH track
is pairable but the corresponding MFT track does not have an associated MC
particle. In such cases the match type is now correctly assigned as "wrong".
@aferrero2707
aferrero2707 force-pushed the PWGDQ-matching-training-producer-fix-match-type-assignment branch from 1789b38 to d412958 Compare August 21, 2026 11:47
@aferrero2707

aferrero2707 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@iarsene @mcoquet642 @XiaozhiBai @mguilbau this is a bug fix for the task that produces the ML training input data for the MFT-MCH matching. I have split the PR in two commits, the first with the actual bugfix and the second with the unrelated linter fixes.

Could you please have a look? Thanks!

@aferrero2707
aferrero2707 marked this pull request as ready for review August 21, 2026 12:02
@alibuild

alibuild commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d412958 at 2026-08-22 04:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 1 warnings.'
Found 2 errors and 1 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/d204f4ddda8ae0cc4defe2ec7574433c1c86924e/O2Physics-code-check/errors.txt
PWGDQ/Tasks/mftMchMatcher.cxx:49:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/mftMchMatcher.cxx:318:61: error: no header providing "o2::constants::math::PI" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/d204f4ddda8ae0cc4defe2ec7574433c1c86924e/O2Physics-code-check/warnings.txt
PWGDQ/Tasks/mftMchMatcher.cxx:406:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d412958 at 2026-08-22 16:46:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants