Skip to content

feat: build documentation for diagrams - #183

Merged
arielleleon merged 15 commits into
mainfrom
178-add-diagrams-to-read-the-docs
Jul 17, 2026
Merged

arielleleon merged 15 commits into
mainfrom
178-add-diagrams-to-read-the-docs

Conversation

@arielleleon

@arielleleon arielleleon commented Jun 26, 2026 •

Copy link
Copy Markdown
Collaborator
  • adds readthedocs for the diagrams library

📚 Documentation preview 📚: https://scicomp-docs--183.org.readthedocs.build/en/183/

@arielleleon
arielleleon requested a review from dbirman June 26, 2026 21:25
@arielleleon arielleleon linked an issue Jun 26, 2026 that may be closed by this pull request
@arielleleon
arielleleon marked this pull request as draft June 26, 2026 21:25
@arielleleon
arielleleon marked this pull request as ready for review June 26, 2026 21:37
@dbirman

dbirman commented Jun 26, 2026

Copy link
Copy Markdown
Member

I think something needs to be tweaked, the built version (in the PR comment link) for me doesn't seem to show any of the diagrams?

Screenshot 2026-06-26 at 2 50 27 PM

The diagrams/index.md toctree referenced high_level, mid_level,
low_level, and dynamic_foraging, but those pages were never tracked,
so the published build showed the landing header with no diagrams.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@arielleleon

Copy link
Copy Markdown
Collaborator Author

@dbirman - Try now

@dbirman dbirman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently these seem mostly like reference material, since they are disconnected from the how-to guides where we have most of our docs content. I think that's okay, but I feel like they would be much more useful embedded alongside the relevant content related to each diagram. They don't need to be in-line, they could appear as hover tooltips or something, or link from that content to a page with each of the diagrams.

At a minimum it would be good to provide a text description of each diagram, and probably use the glossary system that Tom set up for definitions of systems that a user might not know in advance.

I think also in an effort to reduce clutter on the left sidebar we should put this under the AIND Resources section, and probably just rename that "Resources". I will revisit the sidebar in the future though to reduce the number of things there, so not necessary to do that now.

@arielleleon

Copy link
Copy Markdown
Collaborator Author

Currently these seem mostly like reference material, since they are disconnected from the how-to guides where we have most of our docs content. I think that's okay, but I feel like they would be much more useful embedded alongside the relevant content related to each diagram. They don't need to be in-line, they could appear as hover tooltips or something, or link from that content to a page with each of the diagrams.

At a minimum it would be good to provide a text description of each diagram, and probably use the glossary system that Tom set up for definitions of systems that a user might not know in advance.

I think also in an effort to reduce clutter on the left sidebar we should put this under the AIND Resources section, and probably just rename that "Resources". I will revisit the sidebar in the future though to reduce the number of things there, so not necessary to do that now.

Yeah - this fits. I will add some documentation and put them under the Resources section

@arielleleon
arielleleon marked this pull request as draft June 30, 2026 16:02
@patricklatimer

Copy link
Copy Markdown
Contributor

Looking at the built docs, it looks like the transparent images aren't working correctly for dark/light mode.

{3202F05A-1114-42CD-B149-BF5B97656BA3} {17D317E4-D7D4-4183-8ECC-4E6FE35BB89C}

@dougollerenshaw

Copy link
Copy Markdown
Contributor

Two things I'd like to see fleshed out:

  1. All three of the Data Acquisition, Data Staging and Data Storage and Processing diagrams should be more explicit about how simultaneous multi-modal acquisitions are set up. Some things that should be clear from diagrams:
  • How are acquisition and instrument files named when two modalities are running simultaneously?
  • At what point in the flow are multi-modal instrument and acquisition JSON files merged?
  • What specific process handles the merge (there should probably be a block that specifically covers this. I think it's the GatherMetadataJob inside the Metadata Mapper, but I'm not completely sure)
  1. The distinction between creating valid metadata on the rigs vs extractor/mapper pattern should be shown explicitly in the diagrams. Not sure which one this belongs in. But this has been a consistent source of confusion, so we should make a clear distinction between:
  • Generating aind-schema compliant acquisition metadata at the rig (no further action needed)
  • Generating non-compliant extracted metadata at the rig, which is followed by a validation step against the model in the extractor repo, then a call to the metadata mapper to actually generate the aind-schema compliant metadata.

@dougollerenshaw

Copy link
Copy Markdown
Contributor

Minor, but important. The text in the Data Storage and Processing diagrams is unreadably small in the pre-merge rendered version (https://scicomp-docs--183.org.readthedocs.build/en/183/diagrams/data_storage_processing.html)

image

Drops the low-level processing diagram from the Dynamic Foraging page so
it no longer renders on the published docs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@arielleleon

Copy link
Copy Markdown
Collaborator Author

Two things I'd like to see fleshed out:

  1. All three of the Data Acquisition, Data Staging and Data Storage and Processing diagrams should be more explicit about how simultaneous multi-modal acquisitions are set up. Some things that should be clear from diagrams:
  • How are acquisition and instrument files named when two modalities are running simultaneously?
  • At what point in the flow are multi-modal instrument and acquisition JSON files merged?
  • What specific process handles the merge (there should probably be a block that specifically covers this. I think it's the GatherMetadataJob inside the Metadata Mapper, but I'm not completely sure)
  1. The distinction between creating valid metadata on the rigs vs extractor/mapper pattern should be shown explicitly in the diagrams. Not sure which one this belongs in. But this has been a consistent source of confusion, so we should make a clear distinction between:
  • Generating aind-schema compliant acquisition metadata at the rig (no further action needed)
  • Generating non-compliant extracted metadata at the rig, which is followed by a validation step against the model in the extractor repo, then a call to the metadata mapper to actually generate the aind-schema compliant metadata.

@dougollerenshaw - A lot of these will be generated and added to the RTD through this issue #92 . @jtyoung84 , @patricklatimer and I will continue to iterate on the documentation as we resolve issues from the previously referenced issue

@arielleleon
arielleleon marked this pull request as ready for review July 17, 2026 16:02
@arielleleon
arielleleon merged commit 2a09974 into main Jul 17, 2026
1 check passed
@arielleleon
arielleleon deleted the 178-add-diagrams-to-read-the-docs branch July 17, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add diagrams to read the docs

4 participants