Repository navigation
fix(voice): correct pinned Paradee v1.1 file size - #608
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host speech manifest pairs the Paradee v1.1 SHA-256 with the old v1.0 size, 32,072,768 bytes.
admitSpeechrequires an exact size, so it rejects the pinned v1.1 model even when its hash is correct.Use 31,275,232 bytes, as recorded by the exact engine gitlink
6003a10368d8a6d5fb1f70fe9c63a70866e8bcffintools/paradee/pins.json. The model hash remains unchanged. This supports the native speech work in #381 and the implementation plan.Validation:
npm run verifyfailed exactly one consistency check: the pinned upstreamhost-tts-worker.tsalso has the stale v1.0 size. This draft must wait for an upstream correction and reviewed pin adoption. Do not weaken the consistency test or edit the vendored checkout.npm run android:buildandnpm run android:build:localboth stop at the existing missing qualified voice-output preflight. No APK, emulator, AOSP, provider, or device acceptance is claimed.