Repository navigation
Align Android instrumentation with required production sign-in - #610
Merged
Merged
Conversation
lalalune
marked this pull request as ready for review
October 23, 2026 01:59
lalalune
changed the base branch from
codex/adopt-reviewed-voice-browser-fixes
to
main
October 23, 2026 01:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh flag-off installs now show the required full-page Cloud sign-in screen. Android instrumentation still waits for the retired connection dialog or tries to open authenticated views, producing misleading failures.
Update the no-mock assertions to require the sign-in page and reject its dismissal. Split shell bridge validation from its authenticated composer journey so fresh installs retain bridge coverage. Browser, launcher and Settings role journeys use the existing explicit sign-in prerequisite; a skip is not acceptance evidence and no authentication bypass is introduced.
Stacked on #609. Draft pending rebuilt Android instrumentation and an emulator rerun.
JAVA_HOME=/usr/lib/jvm/java-21-openjdk ANDROID_HOME=/home/shaw/Android/Sdk npm run verifypassed (1,796 passed, 6 skipped, no failures), including typecheck and production bundle audit. An initial unconfigured run failed three JVM tests because JAVA_HOME was missing. Both required native build commands were attempted and stop at the existing unqualified voice-assets prerequisite. The original Cloud APK run reproduces the old selector/navigation failures in both variants; startup readiness and synthetic callback delivery pass, not live account login.Fresh Cloud-profile build with these instrumentation changes: https://github.com/AlphaCompute/alphaphone/actions/runs/39886926759 (running). The original emulator run has finished; it restored stock HOME and removed its test installs. Rebuilt instrumentation acceptance remains pending.