Repository navigation
Conversation
…ge in any order Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing: not needed. The feature PRs will be merged in a fixed order instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One change to the files the five open feature PRs (#23, #24, #26, #27, #33) all edit. With it merged, they merge onto main in any order with no conflicts and the tests green. Merge this PR first.
What changes, and which PR needs it
hooks/features/index.ts,hooks/tool-chain.ts,hooks/tool-chain.test.ts,hooks/features/index.test.ts: the wiring feat(runs): record each dbt run's results and show them in /runs #27 (abashDroppedphase: a call a gate refused, or whose result is a refusal, is reported to the features) and feat: dbt helpers from dbt Power User in Claude Code sessions (1.6.0) #23 (acallStartphase, a per-phase deadline for the edit phase, and the dbt helpers' calls in every phase and in the band). Each hunk is the one the feature branch has.hooks/features/runs.tsxgets a no-opbashDropped, and a newhooks/dbt-mods.tsxgets no-op exports for the dbt helpers, the same placeholder pattern the other feature files use. feat(runs): record each dbt run's results and show them in /runs #27 and feat: dbt helpers from dbt Power User in Claude Code sessions (1.6.0) #23 fill them in. On main nothing changes at run time.hooks/features/docs.test.tsx: the fake CLI sets the dbt helpers off for these tests (feat: dbt helpers from dbt Power User in Claude Code sessions (1.6.0) #23), answers the project health check'sdbt_healthwith nothing to report (feat: project health: new DataPilot issues on changed models, in the band, with an optional push gate #33), and refusesdocs_share_comments(feat: team comments from shared dbt docs in Claude's context and a /comments pane #26). Written once, so the three edits to the same lines no longer conflict.README.md: the Settings intro, which feat: project health: new DataPilot issues on changed models, in the band, with an optional push gate #33 and feat: dbt helpers from dbt Power User in Claude Code sessions (1.6.0) #23 each rewrote. Written once for both; it describes the features as they land..gitignore:node_modules/(feat: hold dbt run, build and show over the BigQuery scan limit until allowed #24).Left with the feature PRs
The parts of
plugin.json,README.md,CHANGELOG.mdandtypes/index.d.tsthat only one PR edits, or that already merge cleanly: they are each feature's own.Verification
claude plugin validate --strict .passes, plugin tests 532 pass / 0 fail,tests/*.sh7/7, pytest 65.Merge this PR before the feature PRs.
🤖 Generated with Claude Code