Repository navigation
feat: the cost check holds over-limit dbt runs on Snowflake and Databricks #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a6d1b84
feat: the cost check holds over-limit runs on Snowflake and Databrick…
hkaltai 914ce2f
docs: maxScanBytes and the README name the Snowflake and Databricks p…
hkaltai c04a446
fix: a recorded hold keeps which planner made its estimate
hkaltai e71c6ef
test: the band's held line names the plan estimate; so does a hold th…
hkaltai f35afbe
Merge remote-tracking branch 'origin/main' into feat/cost-check-snowf…
hkaltai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor (wording, real): on Databricks the estimate is an
EXPLAIN COSTon the SQL warehouse the profile connects to. altimate-code #1768's tool description says this starts the warehouse if it is stopped, and it is billed while up. Neither this description nor the README row tells the user.It doesn't block. The estimate runs only just before a
dbt run,buildorshowof one named model (orshow --inline) on the default target, which would start the same warehouse anyway. Only a hold, or an explicit/scan-cost, starts it without the command following. It runs one at a time per project, within a 120 s budget. Base already makes the same call once the new CLI is installed.Suggest adding a short clause here and in the README row, e.g. "On Databricks the estimate runs on the SQL warehouse, which starts it if stopped." Codex rated this major at first, then accepted minor on that evidence.