Repository navigation
fix: project health follow-ups, cost planner label, altimate-dbt docs - #41
Conversation
…led-session gate), cost planner label kept, altimate-dbt docs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
| // What is shown never decides the gate: a failure here must not let a scan the gate knows is over the limit through. | ||
| try { | ||
| await update($, costAtom, prev => ({ ...(prev ?? FRESH), lastEstimate: { target, bytes, display } })) | ||
| await update($, costAtom, prev => ({ ...(prev ?? FRESH), lastEstimate: { target, bytes, display, ...(planner && { planner }) } })) |
There was a problem hiding this comment.
SUGGESTION: planner is now written into lastEstimate, but its declared shape was not updated.
CostState.lastEstimate in types/index.d.ts:507 is still { target: string; bytes: number; display: string }, so the persisted state and its documented type disagree (the sibling held field already declares planner?: string). Reading last.planner anywhere later would fail typecheck, and the type comment no longer describes what is stored. Add planner?: string there (the spread hides the excess property from typecheck here).
There was a problem hiding this comment.
Fixed in 2a08944: planner?: string is declared on CostState.lastEstimate.
|
|
||
| import { PHASE_TIMEOUT_MS } from './tool-chain' | ||
| import { GATE_WAIT_MS, bandText, canonical, configPathProblem, filesWrittenBy, isGitPush, modelsOfFiles, newIssues, pairKey, pushRefusal, reportText, simpleCommands, toolArgs } from './features/health' | ||
| import { GATE_WAIT_MS, bandText, bashAfter, canonical, configPathProblem, filesWrittenBy, isGitPush, modelsOfFiles, newIssues, pairKey, pushRefusal, reportText, simpleCommands, toolArgs } from './features/health' |
There was a problem hiding this comment.
SUGGESTION: bashAfter is imported here but never used.
The new tests (lines 868-913) exercise the after-phase through $.tool.call(...), not by calling bashAfter directly, so this name is dead in the import list. Drop it so the import keeps matching what the file uses.
There was a problem hiding this comment.
Fixed in df2497a: the unused import is removed.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The incremental change removes the unused Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit 2a08944)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2a08944)Status: 1 Issue Found | Recommendation: Address before merge Overview
The incremental change is a one-line fix: Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous review (commit 7f43f88)Status: 2 Issues Found | Recommendation: Address before merge Overview
The functional changes check out: the Issue Details (click to expand)SUGGESTION
Fix these issues in Kilo Cloud Files Reviewed (8 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 0 · Output: 0 · Cached: 0 |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at 2a08944 (reviewers: gpt-6-astra high, gpt-6.1-sol high) |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at df2497a (reviewers: gpt-6-astra high, gpt-6.1-sol high) |
…ng 1.8.2) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at 8c389fc (reviewers: gpt-6-astra high, gpt-6.1-sol high) |
saravmajestic
left a comment
There was a problem hiding this comment.
LGTM. The per-call start folder (tool_use_id, newest 50 kept), the ${#name} comment fix, and the early return when no dbt project is enabled all look right, and both Kilo findings are fixed. Locally: 1231 pass, 0 fail, and 1264/0 merged with #42 on main. The two conflict only in CHANGELOG.md.
Follow-ups from the merged project health (#33) and scan-cost (#39) reviews, plus a docs section.
Changes
cdis kept per call (tool_use_id), so an overlapping call (a subagent's) no longer loses it and leaves a written model unchecked.echo ${#arr[@]}; git pushis read as a push (the#of${#name}is not a comment)./scan-costwith no model keeps the planner label of the last Snowflake or Databricks estimate.altimate-dbtsection (what it is, what the agent uses it for, that users need not run it, link to the docs).Not changed
state.running ||clause in the push decision cannot be observed on its own: the chain's outer bound reports first, so no test can tell it apart.cdcommand with no noted start folder is unreachable without outlasting the chain deadline; the null-folder path to the same root is tested.Test plan
claude plugin test plugins/altimate-code(1191 pass; the known artifact-read race test is the only failure)claude plugin validate --strict .bash tests/*.sh🤖 Generated with Claude Code