Skip to content

dbt-tools: pin the stale-manifest fixes, describe the stale shape, let Fusion skip the Python check #1756

Open

Description

@ralphstodomingo

Follow-ups from the review of #1704 (dbt-tools stale-manifest notes and @altimateai/dbt-integration 0.3.19). None of them blocked that PR.

What's missing

  1. No test pins the 0.3.19 stale-manifest fix. Answered from the last successful parse, children and parents no longer mark every node isExternalProject: true. That was verified by hand, but nothing in dbt-tools' tests would catch a later bump that regresses it.
  2. The skill references don't describe the stale shape. USAGE says children and parents answer { stale_manifest, models } when the project check fails. The six altimate-dbt-commands.md references under .opencode/skills/*/references/ still describe a plain list, and those are the files agents read for impact analysis.
  3. dbt Fusion without Python stops at altimate-dbt's prerequisite check. The library runs Fusion without a Python interpreter, but altimate-dbt runs its prerequisite check (check.ts) before every command but doctor. That check fails when there is no Python path, or no dbt-core in it, whatever dbtIntegration is. So a Fusion-only setup still gets "Prerequisites not met".
  4. Small gaps in the schema-verify stale note:
    • an empty written_at renders as (written «»);
    • its tests have no case for a non-string written_at;
    • its tests have no mixed run where only one model's answer is stale;
    • the current-manifest control doesn't assert that the message equals the one before the change.

Proposed

  • A dbt-tools test that drives the stale path (readManifestLeftOnDisk, as stale-manifest.test.ts sets it up) and asserts isExternalProject: false.
  • One line in each of the six references: when the project check fails, the answer is { stale_manifest, models } and may predate the current files.
  • Skip the Python and dbt-core checks when dbtIntegration is fusion, and check that a dbt 2.x binary resolves instead.
  • Trim written_at before quoting it, and add the three test cases.

Activity

  1. ralphstodomingo commented on Nov 17, 2026

    @ralphstodomingo
    ContributorAuthor

    Follow-ups left after #1757, from its review. None blocks it.

    1. The library's PATH lookup: a dbt on PATH that isn't executable hides a working Fusion later on PATH. resolveOnPath takes the first regular file named dbt, and doesn't try the next one when running it fails. The fix belongs in @altimateai/dbt-integration.
    2. doctor's USAGE text still says "Check prerequisites (Python, dbt, project)". In Fusion mode doctor checks fusion and project.
    3. "next to " in the not-found message also appears for a bare name such as python3, which the lookup doesn't search next to.
    4. The end-to-end stale test covers children only. Add parents.
    5. No test pins the adapter's pythonPath ?? "".
    6. The dbt-cli fallbacks aren't Fusion-aware (pre-existing). In Fusion mode execDbtLs, execDbtCompile and execDbtShow resolve dbt without checking that it is Fusion.
    7. The stale note follows the reason line (from the review of fix(dbt-tools): say when schema-verify's verdict rests on a stale manifest #1704). The agent reads the mismatch before learning that the spec came from a stale manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions