Repository navigation
fix: [AI-11331] name the workspace and signed-in account when a link hits a hidden workspace #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4e0b502
fix: name the workspace and signed-in account when a link hits a hidd…
hkaltai 7be2850
fix: name the account the failing link request ran as
hkaltai d463b91
test: cover an account answer with no email; tidy the shared sanitize…
hkaltai b5e998c
fix: close the picker before the account lookup; bound and validate m…
hkaltai 4ae061b
fix: record each link under the account its write ran as
hkaltai 33d4e2f
refactor: share the code-point clip between workspace names and messa…
hkaltai c725ecc
fix: close the picker when a link's account changes mid-request
hkaltai fc8ba55
fix: run the already-linked create and its rebind as the captured acc…
hkaltai 9f5b8e2
fix: derive the pre-rebind account check from the captured credential
hkaltai b5f64c7
fix: create nothing when no credential can be captured
hkaltai dcf6067
Merge remote-tracking branch 'origin/main' into fix/slack-reported-ba…
hkaltai 974bbf1
fix: read the create's credential once, before the spinner starts
hkaltai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.