Rename WebSocketDataCallback's frame param from opcode to bits - #9
Rename WebSocketDataCallback's frame param from opcode to bits#9heshammahamed wants to merge 1 commit into
Conversation
The parameter was named `opcode`, but civetweb actually passes the raw first byte of the WebSocket frame header (FIN flag + reserved bits + the real opcode packed into the low 4 bits), not the opcode alone. Renamed to `bits` to match civetweb's own naming, and updated the docs (EN + AR) and examples to match this correct understanding.
|
Where did you get that info about Civetweb from, and is their documentation wrong? In their documentation the |
|
I think this is a problem in their Docs. this is from civetweb's own header :
search on it in this file to make sure : https://github.com/civetweb/civetweb/blob/master/include/civetweb.h |
The parameter was named
opcode, but civetweb actually passes the raw first byte of the WebSocket frame header (FIN flag + reserved bits + the real opcode packed into the low 4 bits), not the opcode alone. Renamed tobitsto match civetweb's own naming, and updated the docs (EN + AR) and examples to match this correct understanding.