Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle the degenerate bpref cases using the TREC eval convention: when a query has no judged nonrelevant documents, each retrieved relevant document contributes 1; when it has no relevant documents, its score is 0. This prevents NaN scores for positive-only qrels. Regression coverage includes partial relevant retrieval (expected score 1/2), unjudged retrieved documents, and a custom
rel_lvl.Validation
7363db0c35e92e90d6fa6fe73907b760678f765e, both partial-retrieval parameter cases returnednanand failed the expected0.5assertion./tmp/ranx-test-venv/bin/pytest -q tests/unit/ranx/metrics: 10 passed.UP007findings on unchangedUnion[...]signatures inranx/metrics/bpref.py(lines 52–53).