Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes #706.
Expo SDK 58's scene-based AppDelegate template no longer declares the URL and user-activity overrides that the plugin searches for. Prebuild finishes with a warning and leaves out the AppsFlyer calls.
When those methods are absent from an
AppDelegate: ExpoAppDelegate, the plugin now inserts them. Each calls the existing AppsFlyer attribution facade and forwards tosuperso Expo's subscribers still receive the event. Expo'sSceneEventForwarderhandles React Native link delivery for this template.Existing handlers keep their bodies. The plugin does not add a duplicate when it finds a handler with custom formatting it cannot instrument; that case retains the manual-integration warning. Objective-C handling is unchanged.
The report used AppsFlyer 6.18.0. This PR targets current master (7.0.2) and uses its attribution facade; it is not a v6 backport.
Validation
npm run lintpasses.I have not tested cold/warm attribution delivery against an AppsFlyer account. The native build check uses SDK 58; older SDK compatibility is checked through the generated-source regression tests.
Standalone reproduction: https://github.com/1kuko3/appsflyer-expo-58-prebuild-repro