Skip to content

Sync development with 7.0.2 release fixes + repair README/bump-version staleness - #434

Merged
af-obodovskyi merged 8 commits into
developmentfrom
dev/fix-versions-readme
Sep 17, 2026
Merged

af-obodovskyi merged 8 commits into
developmentfrom
dev/fix-versions-readme

Conversation

@af-obodovskyi

Copy link
Copy Markdown
Contributor

Summary

  • development was 7 commits behind master — it never received the fixes shipped in the 7.0.2 release line (PRs Release 7.0.2-rc9 #432/fix(release): repair production package validation and versioning #433). This PR brings those in, plus one new fix on top.
  • New fix: README's "This plugin is built for" block (native Android/iOS AppsFlyer SDK + Purchase Connector versions) was stale (6.17.x/2.2.0) and fed directly into the production release Slack notification, which greps those exact lines. Root cause was bump-version.sh's update_doc_rpc_versions() targeting patterns that don't match README's actual line format, and never accepting native SDK versions as input in the first place — so these lines could never have been kept in sync by any past bump.

What's included

  • d671113 — fix .af-smoke/rc-test-plan.json startSDK→start naming mismatches (post-RPC-bridge-rewrite drift)
  • 1484ecf — update-sdk-links.sh now reads af-android-plugin-bridge (the artifact actually declared in AppsFlyerDependencies.xml) instead of the no-longer-declared af-android-sdk
  • 92d3bfb — remove dead assertions in validate-production-package.py/extractPackage.py for native iOS APIs removed by the RPC bridge rewrite; fix deploy/build_unity_package.sh/deploy/strict_mode_build_package.sh silently ignoring --version; update strictMode.md
  • 0587443 — correct README's stale SDK/PC versions; add --android-sdk-version/--ios-sdk-version to bump-version.sh (wired into AppsFlyerDependencies.xml + gradle.properties) and fix update_doc_rpc_versions() to target the README lines that actually exist; wire the new flags through rc-release.yml as optional inputs

af-margot and others added 8 commits September 16, 2026 13:44
…heck

AppsFlyerDependencies.xml no longer declares af-android-sdk directly
(only af-android-plugin-bridge, which pulls it in transitively), so
read_android_package_version("af-android-sdk") returned empty and
require_version exited 1 in promote-release.yml's "Update installation
links" step.

The docs/Installation.md manual "AppsFlyer Android SDK" download link
is left untouched rather than rewritten to af-android-plugin-bridge,
since that artifact is a thin wrapper that doesn't work standalone for
drag-and-drop installs without its own transitive deps.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Four issues found auditing the production release pipeline, all stemming
from the RPC bridge rewrite (1507c8c) and a --version flag that was never
actually wired up:

- validate-production-package.py and extractPackage.py both asserted that
  AppsFlyeriOSWrapper.mm contains commented-out disableAdvertisingIdentifier
  and waitForATTUserAuthorizationWithTimeoutInterval calls. Both APIs were
  removed entirely (regular and strict alike) by the RPC rewrite, so these
  checks could never pass again and would fail every future release.
  extractPackage.py's check is independent of validate-production-package.py's
  and runs earlier in check_packages.yml, so both needed fixing.

- deploy/build_unity_package.sh and deploy/strict_mode_build_package.sh
  accepted --version <value> but discarded it, always emitting whatever
  PACKAGE_NAME string was hardcoded as the default. Every past release
  relied on manually re-hardcoding that string in sync with the version
  bump commit; the CLI flag itself was decorative. Fixed to build
  PACKAGE_NAME from the passed argument.

- strictMode.md's doc bullet claiming the two removed APIs are strict-mode
  specific is now stale; updated to reflect they're gone entirely.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix(release): repair production package validation and versioning
… doc sync

README's "built for" block (Android/iOS AppsFlyer SDK, Purchase Connector
versions) was stale (6.17.x/2.2.0), which fed directly into the production
release Slack notification since that step greps these exact lines.

Root cause: bump-version.sh's update_doc_rpc_versions() targeted patterns
("- af-android-plugin-bridge X", "- AppsFlyerRPC X") that don't exist in
README - the actual lines are "- Android AppsFlyer SDK vX" / "- iOS AppsFlyer
SDK vX" - and the script never accepted native SDK version inputs at all, so
these lines could never be kept in sync on any past bump.

Add --android-sdk-version/--ios-sdk-version to bump-version.sh, wire them
into AppsFlyerDependencies.xml (AppsFlyerFramework-Dynamic remoteSwiftPackage
+ AppsFlyerFramework iosPod) and gradle.properties (ANDROID_SDK_VERSION), and
fix update_doc_rpc_versions() to patch the README lines that actually exist.
Wire the new flags through rc-release.yml as optional workflow_dispatch
inputs. Also correct README's currently-stale values directly (7.0.1/2.3.0/
7.0.2/7.0.2).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@af-obodovskyi
af-obodovskyi merged commit 18399ad into development Sep 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants