Skip to content

Sync master with README/bump-version fix from development #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
af-obodovskyi merged 2 commits into from
Sep 17, 2026
Merged

Sync master with README/bump-version fix from development #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0587443
fix(release): correct stale README SDK versions and repair native-SDK…
af-obodovskyi Sep 17, 2026
18399ad
Merge pull request #434 from AppsFlyerSDK/dev/fix-versions-readme
af-obodovskyi Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/rc-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ on:
required: false
default: "8.0.0"
type: string
android_sdk_version:
description: "Native Android AppsFlyer SDK version (af-android-sdk, pulled in transitively by af-android-plugin-bridge). Pass when it differs from the current gradle.properties value — also updates README's \"built for\" block."
required: false
default: ""
type: string
ios_sdk_version:
description: "Native iOS AppsFlyer SDK version (AppsFlyerFramework / AppsFlyerFramework-Dynamic). Pass when it differs from the current AppsFlyerDependencies.xml value — also updates README's \"built for\" block."
required: false
default: ""
type: string

permissions:
contents: read
Expand Down Expand Up @@ -168,6 +178,8 @@ jobs:
[[ -n "${{ inputs.ios_pc_version }}" ]] && BUMP_ARGS+=(--ios-pc-version "${{ inputs.ios_pc_version }}")
[[ -n "${{ inputs.android_pc_version }}" ]] && BUMP_ARGS+=(--android-pc-version "${{ inputs.android_pc_version }}")
[[ -n "${{ inputs.android_billing_version }}" ]] && BUMP_ARGS+=(--android-billing-version "${{ inputs.android_billing_version }}")
[[ -n "${{ inputs.android_sdk_version }}" ]] && BUMP_ARGS+=(--android-sdk-version "${{ inputs.android_sdk_version }}")
[[ -n "${{ inputs.ios_sdk_version }}" ]] && BUMP_ARGS+=(--ios-sdk-version "${{ inputs.ios_sdk_version }}")
scripts/bump-version.sh "${BUMP_ARGS[@]}"

- name: Verify version bump
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ To do so, please follow [this article](https://support.appsflyer.com/hc/en-us/ar

### <a id="plugin-build-for"> This plugin is built for

- Android AppsFlyer SDK v6.17.6
- Android Purchase Connector 2.2.0
- iOS AppsFlyer SDK v6.17.9
- Android AppsFlyer SDK v7.0.1
- Android Purchase Connector 2.3.0
- iOS AppsFlyer SDK v7.0.2
- iOS Purchase Connector 7.0.2
---
## 📌 RPC-schema-aligned plugin core + new async API surface
Expand Down
44 changes: 38 additions & 6 deletions scripts/bump-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ UNITY_WRAPPER_VERSION=""
ANDROID_PC_VERSION=""
IOS_PC_VERSION=""
ANDROID_BILLING_VERSION=""
ANDROID_SDK_VERSION=""
IOS_SDK_VERSION=""

while [[ $# -gt 0 ]]; do
case "$1" in
Expand All @@ -33,6 +35,8 @@ while [[ $# -gt 0 ]]; do
--android-pc-version) ANDROID_PC_VERSION="$2"; shift 2 ;;
--ios-pc-version) IOS_PC_VERSION="$2"; shift 2 ;;
--android-billing-version) ANDROID_BILLING_VERSION="$2"; shift 2 ;;
--android-sdk-version) ANDROID_SDK_VERSION="$2"; shift 2 ;;
--ios-sdk-version) IOS_SDK_VERSION="$2"; shift 2 ;;
*) echo "Unknown option: $1"; exit 1 ;;
esac
done
Expand All @@ -53,6 +57,8 @@ echo " unity-wrapper: $UNITY_WRAPPER_VERSION"
echo " ios-pc: ${IOS_PC_VERSION:-"(unchanged)"}"
echo " android-pc: ${ANDROID_PC_VERSION:-"(unchanged)"}"
echo " android-billing: ${ANDROID_BILLING_VERSION:-"(unchanged)"}"
echo " android-sdk (native): ${ANDROID_SDK_VERSION:-"(unchanged)"}"
echo " ios-sdk (native): ${IOS_SDK_VERSION:-"(unchanged)"}"
echo ""

# ── 1. Assets/AppsFlyer/package.json ─────────────────────────────────────────
Expand Down Expand Up @@ -92,6 +98,12 @@ if [[ -n "$ANDROID_PC_VERSION" ]]; then
echo "[6b/11] $DEPS_XML — purchase-connector (Android)"
sed -i.bak "s|spec=\"com.appsflyer:purchase-connector:[^\"]*\"|spec=\"com.appsflyer:purchase-connector:$ANDROID_PC_VERSION\"|" "$DEPS_XML"
fi

if [[ -n "$IOS_SDK_VERSION" ]]; then
echo "[6c/11] $DEPS_XML — native iOS AppsFlyer SDK (AppsFlyerFramework-Dynamic / AppsFlyerFramework pod) → $IOS_SDK_VERSION"
sed -i.bak "s|url=\"https://github.com/AppsFlyerSDK/AppsFlyerFramework-Dynamic.git\" version=\"[^\"]*\"|url=\"https://github.com/AppsFlyerSDK/AppsFlyerFramework-Dynamic.git\" version=\"$IOS_SDK_VERSION\"|" "$DEPS_XML"
sed -i.bak "s|name=\"AppsFlyerFramework\" version=\"[^\"]*\"|name=\"AppsFlyerFramework\" version=\"$IOS_SDK_VERSION\"|" "$DEPS_XML"
fi
rm -f "${DEPS_XML}.bak"

# ── 7. android-unity-wrapper/gradle.properties ───────────────────────────────
Expand All @@ -115,6 +127,14 @@ if [[ -f "$ANDROID_WRAPPER_PROPS" ]]; then
echo "ANDROID_PC_VERSION=$ANDROID_PC_VERSION" >> "$ANDROID_WRAPPER_PROPS"
fi
fi
if [[ -n "$ANDROID_SDK_VERSION" ]]; then
echo " ANDROID_SDK_VERSION=$ANDROID_SDK_VERSION (native af-android-sdk)"
if grep -q "^ANDROID_SDK_VERSION=" "$ANDROID_WRAPPER_PROPS"; then
sed -i.bak "s|^ANDROID_SDK_VERSION=.*|ANDROID_SDK_VERSION=$ANDROID_SDK_VERSION|" "$ANDROID_WRAPPER_PROPS"
else
echo "ANDROID_SDK_VERSION=$ANDROID_SDK_VERSION" >> "$ANDROID_WRAPPER_PROPS"
fi
fi
rm -f "${ANDROID_WRAPPER_PROPS}.bak"
fi

Expand All @@ -132,15 +152,20 @@ if [[ -f "$UNITYWRAPPER_BUILD" ]]; then
fi

# ── 9. deploy/build_unity_package.sh ────────────────────────────────────────
# Only touch the top-of-file fallback default. The --version case branch builds
# PACKAGE_NAME from $2 at runtime and must never be overwritten with a literal —
# that's exactly the bug (--version silently ignored) fixed in that script; a
# blind s|| here would clobber the fix back in on every future version bump.
BUILD_SH="deploy/build_unity_package.sh"
echo "[9/11] $BUILD_SH"
sed -i.bak "s|PACKAGE_NAME=\"appsflyer-unity-plugin-[^\"]*\.unitypackage\"|PACKAGE_NAME=\"appsflyer-unity-plugin-${PLUGIN_VERSION}.unitypackage\"|" "$BUILD_SH"
sed -i.bak "/PACKAGE_NAME=\"appsflyer-unity-plugin-\$2/!s|PACKAGE_NAME=\"appsflyer-unity-plugin-[^\"]*\.unitypackage\"|PACKAGE_NAME=\"appsflyer-unity-plugin-${PLUGIN_VERSION}.unitypackage\"|" "$BUILD_SH"
rm -f "${BUILD_SH}.bak"

# ── 10. deploy/strict_mode_build_package.sh ──────────────────────────────────
# Same reasoning as step 9 — skip the --version case branch's $2-derived line.
STRICT_SH="deploy/strict_mode_build_package.sh"
echo "[10/11] $STRICT_SH"
sed -i.bak "s|PACKAGE_NAME=\"appsflyer-unity-plugin-strict-mode-[^\"]*\.unitypackage\"|PACKAGE_NAME=\"appsflyer-unity-plugin-strict-mode-${PLUGIN_VERSION}.unitypackage\"|" "$STRICT_SH"
sed -i.bak "/PACKAGE_NAME=\"appsflyer-unity-plugin-strict-mode-\$2/!s|PACKAGE_NAME=\"appsflyer-unity-plugin-strict-mode-[^\"]*\.unitypackage\"|PACKAGE_NAME=\"appsflyer-unity-plugin-strict-mode-${PLUGIN_VERSION}.unitypackage\"|" "$STRICT_SH"
rm -f "${STRICT_SH}.bak"

# ── 11. test-app/Assets/Plugins/Android/mainTemplate.gradle ──────────────────
Expand Down Expand Up @@ -269,12 +294,19 @@ if [[ -f "$CHANGELOG" ]]; then
rm -f "$BULLETS_FILE"
fi

# ── README.md / docs — native SDK and Purchase Connector version surfaces ─────
# ── README.md / docs — "This plugin is built for" native SDK / PC version block ──
# These lines report the *native* Android/iOS AppsFlyer SDK versions (the values the
# production release Slack notification also reads straight from this file — see
# release_production_workflow.yml's "Read native SDK and Purchase Connector versions
# from README" step), not the af-android-plugin-bridge/AppsFlyerRPC bridge versions.
# Only update what we were actually given; leave the rest unchanged so this never
# clobbers a version that wasn't part of this bump.
update_doc_rpc_versions() {
local file="$1"
[[ -f "$file" ]] || return 0
sed -i.bak "s|- af-android-plugin-bridge [0-9][0-9.]*|- af-android-plugin-bridge $ANDROID_PLUGIN_BRIDGE_VERSION|" "$file"
sed -i.bak "s|- AppsFlyerRPC [0-9][0-9.]*|- AppsFlyerRPC $IOS_RPC_VERSION|" "$file"
[[ -n "$ANDROID_SDK_VERSION" ]] && sed -i.bak "s|- Android AppsFlyer SDK v[0-9][0-9.]*|- Android AppsFlyer SDK v$ANDROID_SDK_VERSION|" "$file"
[[ -n "$IOS_SDK_VERSION" ]] && sed -i.bak "s|- iOS AppsFlyer SDK v[0-9][0-9.]*|- iOS AppsFlyer SDK v$IOS_SDK_VERSION|" "$file"
[[ -n "$ANDROID_PC_VERSION" ]] && sed -i.bak "s|- Android Purchase Connector [0-9][0-9.]*|- Android Purchase Connector $ANDROID_PC_VERSION|" "$file"
[[ -n "$IOS_PC_VERSION" ]] && sed -i.bak "s|- iOS Purchase Connector [0-9][0-9.]*|- iOS Purchase Connector $IOS_PC_VERSION|" "$file"
rm -f "${file}.bak"
}
Expand All @@ -285,7 +317,7 @@ if [[ -f "$README" ]]; then
sed -i.bak "s|af-android-plugin-bridge:[0-9][0-9.]*|af-android-plugin-bridge:$ANDROID_PLUGIN_BRIDGE_VERSION|g" "$README"
sed -i.bak "s|AppsFlyerRPC', '[0-9][0-9.]*|AppsFlyerRPC', '$IOS_RPC_VERSION|g" "$README"
rm -f "${README}.bak"
echo "[+] README.md — updated RPC bridge version references"
echo "[+] README.md — updated RPC bridge and native SDK version references"
fi

INTRO="docs/Introduction.md"
Expand Down