Name the run strategy - #1256
Merged
Merged
Conversation
An active resident has a run strategy, which decides when its next step is due. The class comment calls it that, and so do #newRunStrategy and #runStrategyClass -- only the instance variable and its two accessors were abbreviated to #strategy. That reads fine as long as a resident has no other kind of strategy. A queue does: which index its entries live on and which section of it is a strategy too, and one that has nothing to do with cadence. In one class the short name would then stand for two different things, and the reader has no way to tell which. Nothing on disk is affected. The variable is declared transient, so it never reaches the store -- a stored resident carries #descriptionId, its state and its counters and no strategy slot at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The scanning loop in the prefix range test explains why it needs a second guard, and half of that explanation stopped being true: the cursor is now put one behind the last item of the page rather than left on it. What the guard actually watches is the answer, which is still the last key rather than nil and therefore lies before the key that was asked for. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.