Create a missing fragment file with its header - #1259
Merged
Merged
Conversation
The file the last checkpoint names can be gone, and that is how recovery reaches the journal: it cycles the fragment file when the one named is missing. Writing to a name that is not there opens the file into existence through the write stream, without the header and version #createFragmentFile: writes, and leaves behind a fragment file no reader can make sense of. #currentFragmentFile now creates the file when it is not there instead of opening it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file the last checkpoint names can be gone, and that is how recovery reaches the journal: it cycles the fragment file when the one named is missing. Writing to a name that is not there opens the file into existence through the write stream, without the header and version #createFragmentFile: writes, and leaves behind a fragment file no reader can make sense of.
#currentFragmentFile now creates the file when it is not there instead of opening it.