Backup leaves the journal behind - #1260
Merged
Merged
Conversation
A backup is written by walking the source at a pinned databaseVersion and writing fresh object and index files into a freshly initialized target. The target's positions are therefore its own, and the source's journal entries describe positions in the source. They were copied all the same, file for file. Measured on a database of forty commits, the fragments were half of the copy - and deleting them from it left every value readable. On the ApptiveGrid estate that is half the backup volume and half the transfer, five copies per database per night, for history that cannot be replayed into the copy that holds it. An option rather than a removal: a copy meant to be inspected rather than read may want the history, and a caller that relied on the fragments being there should be able to say so instead of finding out. The target's own fragments are cleared only when the source's are coming in. That deletion exists because a fresh target brings a first fragment whose name collides with the source's first one; with nothing coming in there is nothing to collide with, and that fragment is exactly what a new database should have. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.