Close the journal fragment before deleting it - #1261
Merged
Merged
Conversation
Copying the source journal into a backup first clears the target's own fragment. That fragment is opened lazily, the first time anything touches the target's journal, and Windows refuses to delete a file that is still open; on POSIX the unlink succeeds and the open handle keeps the old inode alive, so this only ever showed on Windows. It is now closed before the delete and forgotten afterwards, so the next write opens a fresh one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying the source journal into a backup first clears the target's own fragment. That fragment is opened lazily, the first time anything touches the target's journal, and Windows refuses to delete a file that is still open; on POSIX the unlink succeeds and the open handle keeps the old inode alive, so this only ever showed on Windows.
It is now closed before the delete and forgotten afterwards, so the next write opens a fresh one.