uv: check libusb_get_config_descriptor return value - #1098
Open
richardw347 wants to merge 1 commit into
Open
richardw347 wants to merge 1 commit into
richardw347 wants to merge 1 commit into
Conversation
libusb leaves *config undefined on failure. The USB3Vision discovery and open paths ignored the return value and immediately dereferenced config, which segfaults (typically at address 4 via bNumInterfaces) when a device is in a bad USB state. Bail out cleanly and skip NULL altsetting pointers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libusb_get_config_descriptor()leaves*configundefined on failure. Several USB3Vision paths ignored the return value and immediately usedconfig->bNumInterfaces/altsetting, which segfaults when the device is in a bad USB state (we hit this assegfault at 4in_usb_device_to_device_idsduring discovery).This change:
config == NULL) in_usb_device_to_device_ids,get_guid_index, and_open_usb_devicealtsettingSame bug pattern still present on main prior to this PR.
Test plan
arv-tool-0.8/arv-camera-test) — still discovers and opens