Skip to content

docs: align MR-14 replay summaries with the stored logical outcome - #35

Merged
deku2026 merged 1 commit into
mainfrom
design/mr14-idempotency
Oct 26, 2026
Merged

deku2026 merged 1 commit into
mainfrom
design/mr14-idempotency

Conversation

@deku2026

@deku2026 deku2026 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

The MR-14 implementation review found that the general idempotency summaries still promised the stored response on every replay, while Design#34 specifies the post-commit WAL checkpoint and transient known-HAPPENED error. Align contracts README section 6 and AD-0004 section 5: dedup retains the logical outcome for 24 h; replay reattempts the checkpoint without repeating deletion or replacing stored bytes. ADR amendment/date included; no proto, schema, new error, policy activation or implementation change.

This resolves the direct-review documentation finding within MR-14. Author Linux zero errors, protoc 25 files/both schemas, 47 tool tests passed, diff clean. Reviewed head f45a6f2, tree 1e93ab47a607ee7f4ccdafe57b8659b8a911da2f, base 3df9db7. Merged as 2d9995e78c4aa0f6327371ab0b5639857718da5c after full native Windows 3 steps/26 s and Linux 3 steps/45 s passed. All six results, runner exit records 0 and required exact-head success statuses read with fresh main/head/tree. Direct review, final gate.

Merged before implementation#56, merge 5fa2ad5fe77bef791b96db11129b3851fe55c940. Source head/tree and its formal-profile inputs stayed unchanged; its own complete native Windows13/1148 s and Linux16/1364 s passed. Windows Design verification ran after source verification drained, with no competing build/test.

OpenAI Codex direct work/review under the explicit no-agent instruction; no independent reviewer claimed. Stop after MR-14 Plan/ledger/stop handoff records merge. No other item starts.

Generated by OpenAI Codex.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

Copy link
Copy Markdown
Contributor Author

Direct self-review at exact head f45a6f2, tree 1e93ab47a607ee7f4ccdafe57b8659b8a911da2f, base 3df9db7. Full two-file diff read against merged MR-14 node-store section 1, errors implicit-code rule, AD-0006 and source ApiCommands.IdempotentAsync/TaskServiceHandler. The stored bytes are parsed to a fresh response before the transient known-HAPPENED checkpoint error; replay never re-deletes the task. The common summaries now state this exception, resolving the implementation review's documentation finding. ADR amendment/date present, differing-payload conflict and all other replay semantics unchanged. No remaining findings. Author: zero errors, protoc 25 files, both schemas, 47 Linux tool tests pass, diff clean. Both exact-head native full required statuses still gate merge. OpenAI Codex direct review under the user's no-agent instruction; no independent reviewer claimed.

Copy link
Copy Markdown
Contributor Author

Native Linux final-head full gate passed: f45a6f2, tree 1e93ab47a607ee7f4ccdafe57b8659b8a911da2f; all 3 summary results read, 45 s, wrapper exit 0 (20261026-095744-f45a6f2deae5-linux). Windows gate remains pending execution until the ongoing implementation Windows full leg drains. No merge yet and no same-host competing build/test.

Copy link
Copy Markdown
Contributor Author

Final gate at f45a6f2, tree 1e93ab47a607ee7f4ccdafe57b8659b8a911da2f: complete native Windows full 3 steps/26 s (20261026-021046-f45a6f2deae5-win) and Linux full 3 steps/45 s (20261026-095744-f45a6f2deae5-linux) passed. All six summary results and both wrapper exit records 0 read; both required engine-reported statuses success at this exact head, owner-hosted check skipped as expected. Windows ran only after the source Windows full leg drained. Fresh main remains 3df9db7; head/tree unchanged. Direct review #35 (comment) leaves no unresolved findings. Merge before source#56; then Plan verifies its own head on both hosts against the new Design main.

@deku2026
deku2026 merged commit 2d9995e into main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant