Repository navigation
fix: scope Windows memory evidence and qualify limit detail (MR-18) - #58
Conversation
…ail (MR-18) Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
…-18) Co-Authored-By: OpenAI Codex <noreply@openai.com>
…MR-18) Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
MR-18 final CI gate exposed slot-time skew under parallel launch load. Keep all fairness assertions and deadlines; move both OS cases to the existing exclusive suite. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
First complete Windows candidate gate fa6f836 failed in win-ci: SchedulerTests.TwoSessionsShareAdmissionsEquallyOnWindows, first12 starts6:6 but measured slot-time share65.3948% outside original40–60%;322 total,283 pass,38 skips,1 failure. Subsequent schema/publish/native/bench/package/exclusive/startup steps were not run; wrapper1/summary false retained (20261026-041700-fa6f83622c8a-win). Diagnosis: FairnessAsync uses300 ms holds but measures admission-to-finish slot occupancy including launch/finalization. The comment claiming independence from below-normal startup was false; both wrappers lacked isolation despite AGENTS requiring exclusive+DisableParallelization for timing/CPU-share-sensitive tests. A single matched fa6f836 idle/isolated diagnostic, with no competing Windows build/test, passed unchanged assertions:6:6 starts,50.5% share,10.048 s. Necessary gate-fixture repair in this PR marks both OS cases exclusive and corrects the comment; no scheduler algorithm, task duration/count,40–60% or5–7 starts assertion, or180 s timeout changed. New head needs both complete native source gates; old fa6f836 Linux leg is allowed to finish cleanly, never used as the new-head gate. Source memory author checks already passed at fa6f836; their code is unchanged by this test-isolation-only delta. Retain all failed/partial/diagnostic evidence, do not blindly replay or weaken validation. Owner's latest instruction: finish MR-18 and records then STOP; do not begin MR-19. |
|
Latest owner instruction supersedes the earlier automatic continuation: finish MR-18 (including all final native gates, actual merges, maintenance list/CLI ledger and stop handoff), then STOP; do not begin MR-19. Final current head15d6717144468ce0be615e8538f858d29b0fed7d/treefed15ef1b4251c08d8bd48afcfe32b2530570e06 differs from fa6f836 only in SchedulerTests timing-isolation attributes/comment; git diff fa6f836..15d6717 -- src tools eng is empty. Initial memory-code authors remain distinct fa6f836 evidence, not final-head required statuses. New-head Windows format/build zero warnings/errors25.83 s, isolated fairness and Repository72/72 passed; both complete native final-head profiles are required afresh. Windows final3 starts now; old Linux fa6f836 final2 is allowed to finish and clean its private units before starting15d6717 on that host. Earlier malformed compound launch left a partial fa6f836 Linux log/controller gone with no summary/exit; native process/PID inspection confirmed no residual compile/test before standalone-nohup full restart. No manual status copy, concurrent same-host formal run, tolerance/timeout reduction or skipped assertion. |
|
Final15d6717 delta author completed on native Windows: changed-file format, Release build0 warnings/errors25.83 s; timed fairness unchanged assertions passed1/1/no skips12.075 s,6 of12 starts/50.9% slot-time share; Repository72/72/no skips3.127 s, clean diff/checkout, wrapper0. Initial fa6f836 memory-code authors are distinct evidence: Windows build12.88 s,JIT own/detail5/5 14.736 s,nested1/1 4.541 s,TaskControl15/15 76.477 s,Job8/8 14.230 s,Repo72/72 3.292 s,Host AOT0warnings/errors42.37 s,AOT-holder own5/5 13.810 s+nested1/1 2.901 s, all no skips/wrapper0; Linux build15.43 s,Repo72/72 .971 s,pureformat14/14 .597 s,Host AOT0warnings/errors47.89 s,clean/wrapper0. No Windows behavior inferred from Linux. fa6f836 Linux full final2 completed naturally16/1349 s and cleaned, retained as OLD-HEAD evidence only; Windows fa6f836 gate failed as recorded. New final15d6717 full Windows final3 already running; native Linux final3 now starts with no competing same-host build/test. Both new exact-head statuses required; no source/runtime code changed betweenfa and15d, only existing-policy timing isolation, but no old-head status reused. Stop after MR-18 records under latest owner instruction, MR-19 unstarted. |
|
Direct self-review by OpenAI Codex alone under explicit user instruction; no independent reviewer claimed. Reviewed full memory-code/contract/test diff atfa6f836 and final SchedulerTests-only delta at current15d6717144468ce0be615e8538f858d29b0fed7d/treefed15ef1b4251c08d8bd48afcfe32b2530570e06, base852d23d8b4daca78cef509cb7a6925b18795b6b1, against merged Design#37/973934c. No unresolved code findings; final exact-head host statuses remain required. Shared own-job predicate preserves MR-17 strict notification/legacy hard comparisons; packet type/key alone never latches a foreign lower limit. Latched true avoids repeat native queries; expected disposed-handle races fail closed without swallowing non-disposal Win32 faults. Detail says evidence/own job/nonzero and unproven refusal, not causal allocation failure. Internal observer/borrowed port are read-only provenance/composition seams, default-null observer; test uses real jobs, shared real IOCP and actual kernel hard packet, never manually posts/calls handler or fabricates counters. Own aggregate stays below own cap; an actual packet is mandatory. Default-forwarding prerequisite timeouts are retained separately, no general forwarding claim. New detail assertions strengthen existing real NodeHost/holder cases; zero/non-crossing/raw/effect guards remain. Necessary final-gate isolation fix follows existing timing-sensitive policy, preserves all fairness values/loads/deadlines/coverage, changes no scheduler/source/runtime/eng code. All private process/job/port lifetimes and fixture cleanup reviewed. Existing author/probe failures and old-head Linux run cannot substitute for the final15d6717 full Windows/Linux gates. Finish current MR-18 records then STOP; no MR-19 work. |
|
Final MR-18 gate and direct review at pushed head Both complete native full profiles passed; all 29 individual summary results, both wrapper exits 0, and the engine-reported exact-head GitHub statuses were read. Windows: 13 steps/1140 s, summary Direct final diff review remains as recorded in #issuecomment-6408391894: own-job accounting/actual thresholds gate packets, MR-17 comparisons remain shared and unchanged, the detail preserves allocation-refusal uncertainty, disposal is guarded, and test provenance comes from real kernel packets/handles. The final SchedulerTests-only delta applies the existing timing isolation policy; all fairness bounds, holds, counts and timeouts remain. No unresolved finding. OpenAI Codex worked/reviewed alone under the owner's instruction; no independent reviewer or other agent is claimed. The failed fa6f836 Windows timing gate, initial incomplete Linux controller run, and old-head Linux success remain separate evidence and do not gate this commit. Design#37 already merged first as |
Confirm the attempt's own job notification/peak or hard-limit peak evidence before latching a Windows memory packet. A nested job's lower cap is not the attempt cap; packet type/key alone was insufficient. Share the predicate with the holder to preserve MR-17 semantics and safely ignore queued packets after disposal. Keep existing nonzero normalization while making detail explicit: own-job evidence accompanies the exit, allocation refusal is not proven. Align contract comments. Design#37 merged first as973934c (full Windows3/12 s,Linux3/44 s). No enum/RPC/schema/package migration,enforcement feature,credential operation or later-feature activation.
Before classification logic unchanged with read-only native provenance/composition seams: Coreab04206 has3 detail failures+2 controls/no skips14.663 s; cc6ddba real shared-port composition gets actual kernel hard packet10, nested peak110678016, own attempt peak117784576<notification268435456, yet old own hit=True,1 failure/no skips4.292 s. Three prior default-parent-forwarding probes timed out on delivery prerequisites; not counted as attribution failures/passes or default-forwarding proof. No manually posted packet,synthetic event/fake counter; shared port/key is explicit and derived from a real root packet.
Memory-code authors atfa6f836 (distinct earlier-head evidence): Windows format/build0 warnings/errors12.88 s,JIT own/detail5/5+nested1/1,AOT-holder5/5+1/1,TaskControl15/15,Job8/8,Repo72/72,Host AOT0 warnings/errors; Linux build0 warnings/errors15.43 s,Repo72/72,pureformat14/14,Host AOT0 warnings/errors47.89 s,wrappers0. Node is real in-process NodeHost with native jobs/holders/queries and isolated external keys; no new standalone native-node nested-dispatcher claim or Windows behavior inferred from Linux pure checks.
First fa6f836 Windows complete gate FAILED win-ci on timed fairness:6:6 starts,65.3948% slot-time share outside unchanged40–60%,1 failed of322; later steps not run. Diagnosis:300 ms holds measured admission-to-finish including startup/finalization, while wrappers lacked existing-required exclusive isolation. Single unchanged-head isolated diagnostic passed50.5%,6:6. Necessary gate-fixture delta marks both OS cases exclusive+DisableParallelization and corrects misleading comment; no scheduler algorithm,holds/counts/assertions/180s timeout changed. Diagnosis.
CURRENT final head
15d6717144468ce0be615e8538f858d29b0fed7d, treefed15ef1b4251c08d8bd48afcfe32b2530570e06, base852d23d8b4daca78cef509cb7a6925b18795b6b1; only SchedulerTests isolation/comment differs fromfa6f836, no src/tools/eng runtime difference. Final-head Windows delta author passed format/build0 warnings/errors25.83 s,fairness1/1 50.9%/6:6,Repo72/72,clean/wrapper0. Author boundary, direct final review.Complete final-head native full profiles PASSED on15d6717: Windows13/1140 s and Linux16/1382 s, all29 individual results/both wrappers0 and both engine-reported exact-head required successes read. Final gate. Source merged as
a4c1b2bf1b8afd0112fb490aa590c3ac8199ac96after Design#37. Initial malformed compound Linux launch left partialfa logs/controller gone, safely inspected before standalone restart. Oldfa Linux full16/1349 s finished/cleaned and remains OLD-HEAD evidence only; final Linux started after it drained, no same-host competing build/test or status copy. Plan#70 merged asf9d386c2daa55131f1136cc71f4d0225b323f46bafter native full Windows4/3 s and Linux4/26 s at record headf77ac48, all8 results and both required statuses passed with fresh Design main973934c. Plan CLI ledger, list, detailed evidence and stop handoff are complete. Both native post-merge audits reconfirmed the three main refs/trees, clean author worktrees and no owned verification/build/test runners. MR-18 is complete; STOP here under the latest owner instruction; MR-19 remains unstarted. MR-16 blocked,MR-07/11/15 deferred unchanged.OpenAI Codex alone under explicit no-other-model/agent instruction; no independent reviewer claimed.
Generated by OpenAI Codex.