Skip to content

Fix: scope Health Connect aggregate null-bucket skip to HEART_RATE only #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarttila merged 1 commit into from
Jul 15, 2026
Merged

Fix: scope Health Connect aggregate null-bucket skip to HEART_RATE only #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/health/android/src/main/kotlin/cachet/plugins/health/HealthPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3277,11 +3277,19 @@ class HealthPlugin(private var channel: MethodChannel? = null) :
val response = healthConnectClient.aggregateGroupByDuration(request)

for (durationResult in response) {
// The result is null if no data is available in the
// bucket — skip it rather than fabricating a zero
// value (a 0 BPM heart rate is not a real data point).
var totalValue = durationResult.result[metricClassType]
?: continue
if (totalValue == null) {
if (dataType == HEART_RATE) {
// A missing heart-rate bucket means no samples were
// recorded in it — skip it rather than fabricating a
// 0 BPM value, which would not be a real data point.
continue
}
// Every other aggregate type (steps, distance, calories, ...)
// legitimately can be zero for a bucket; report it as such
// rather than dropping the bucket.
totalValue = 0
}
if (totalValue is Length) {
totalValue = totalValue.inMeters
} else if (totalValue is Energy) {
Expand Down
Loading