Repository navigation
Conversation
arch-node v0.12.0 (the chain reset) dropped `rollback_status` from processed transactions and `utxo` from account info. arch_sdk 0.10.0 still requires the former, so every confirmed transaction against a v0.12.0 node failed with "missing field `rollback_status`". Success is now `status == Processed` alone; the rolled-back test cases are gone because that state no longer exists, and the mocked replies match the v0.12.0 shape. Co-authored-by: Cursor <cursoragent@cursor.com>
7 of 9 tasks
Author
|
Superseded by #4, released as arch-kit 0.1.8 on arch_sdk 0.12.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
arch-kit 0.1.7 pins
arch_sdk =0.10.0, whoseProcessedTransactionrequiresrollback_status. arch-node v0.12.0 (chain reset, arch-networkf2eb5017f) no longer returns it, so every command that waits for a transaction fails against a v0.12.0 node:This currently blocks arch-lend's and arch-vaults' testnet deploys (testnet is on v0.12.0).
Change
arch_sdk,apl-token,apl-associated-token-account=0.10.0→=0.12.0;arch-satellite-lang-idl=0.31.5→=0.34.0.status == Processed(the rollback concept was removed from the chain).utxofrom test-builtAccountInfos (removed in 0.12); removes the "processed but rolled back" test cases androllback_statusfrom mocked replies so fixtures match the v0.12.0 shape.Compatibility: this build targets v0.12.0+ nodes. Against a pre-0.12 node, replies still carry
rollback_status, which is ignored, so reads and status checks keep working; a rolled-back transaction would no longer be distinguished. Worth a minor bump (0.2.0) when publishing.Test plan
cargo clippy --all-targets -D warnings,cargo test(109 passed)health,faucet(the failing path),arch-balancewith a throwaway keycargo install arch-kit --version …picks it upNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.