Repository navigation
Retry the node health probe in the reusable deploy workflow - #5
Closed
nikolap-dat wants to merge 1 commit into
Closed
nikolap-dat wants to merge 1 commit into
nikolap-dat wants to merge 1 commit into
Conversation
`arch-kit health` samples the block height twice, 2 s apart, and fails when it did not move. A healthy chain still has multi-second gaps between blocks (3.5 s between heights 48004 and 48005 on internal-b at v0.12.0), so a single probe fails the whole deploy whenever it lands in one. prop-amm's deploy run 37778455694 died this way on a chain producing ~9 blocks/s. Probe up to five times, 10 s apart, and fail only when every probe sees a stalled chain. The per-repo adapters already do this; this brings the reusable workflow in line with them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Author
|
Closing: the single-probe flake is accepted; prop-amm re-dispatches on failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arch-kit healthsamples the block height twice, 2 s apart, and fails when it did not move. A healthy chain still has multi-second gaps between blocks: on internal-b at v0.12.0, heights 48004 → 48005 were 3.5 s apart while the chain averaged ~9 blocks/s. prop-amm's deploy run 37778455694 landed its single probe in exactly that gap and failed withblocks are not progressing … height changed from 48005 to 48005 over 2s.This makes the reusable workflow's health step probe up to five times, 10 s apart, failing only when every probe sees a stalled chain. The per-repo adapters (btc-wrapper, ausd-bridge, CLAMM, arch-vaults, arch-lend) already loop this way; prop-amm is the one consumer of the reusable workflow and will bump its pin to this commit.
Test plan
yqon the file)internal-bdeploy passes the health step🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.