Repository navigation
fix: enforce oracle quorum and deterministic tie-break in finalize - #1918
Merged
Conversation
|
@kolawoleoluwaferanmi014-a11y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds explicit quorum enforcement and deterministic tie-breaking to the creator-event-manager oracle consensus flow. Match results can no longer finalize on too few submissions, and tied outcomes now resolve identically across runs instead of depending on map iteration order. The finalizer service and its tests were updated to surface the winning outcome, vote tally, and quorum used.
Related Issue
Changes
🗳️ Oracle Consensus Finalization
[MODIFY]
contracts/creator-event-manager/src/storage_types.rs[ADD]
contracts/creator-event-manager/tests/oracle_consensus_tests.rsQuorumNotMet) and deterministic resolution of exact ties across repeated runs.🔧 Backend Finalizer
[MODIFY]
backend/src/matches/creator-event-finalizer.service.ts[MODIFY]
backend/src/matches/creator-event-finalizer.service.spec.ts[MODIFY]
backend/performance/oracle-load-test.jsVerification Results
QuorumNotMetCloses #1760