Pass every Vela option of the mlops: node to Vela - #23
Merged
Merged
Conversation
create_ai_layer.py picked --accelerator-config, --system-config and --memory-mode out of vela.options of the cbuild-mlops.yml with a regular expression and dropped the rest, so `vela: misc:` in the csolution had no effect and nothing said so. The options are now tokenized; the three that are arguments of EthosUCompileSpec go there and every other one reaches Vela as an extra flag. An option given twice, and --config, --output-format and --output-dir, which the export sets itself, end the script with a message. Without misc: the exported program is byte for byte the one in ai_layer/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create_ai_layer.pyreads--accelerator-config,--system-configand--memory-modefromvela.optionsof the*.cbuild-mlops.ymland ignores everything else.vela: misc:in the csolution'smlops:node therefore has no effect, and nothing reports it:Change
vela_options()tokenizes the option string. The three options that are arguments ofEthosUCompileSpecgo there; every other option is passed to Vela as an extra flag.--config,--output-formatand--output-dir, which the export sets itself (the configuration file isvela: ini:).[ai_layer] Vela:line.Checked
misc:the exported program is byte for byte the one committed inai_layer/, so this PR changes no generated file.misc: --optimise Size --verbose-performancethe flags reach Vela and the program changes (9776 instead of 8832 bytes).