Skip to content

Fix #2: CLI: hide the internal crash worker from public help #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agenticsymphony-tech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #2: CLI: hide the internal crash worker from public help #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commitlatch/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ def main(argv=None):
parser = argparse.ArgumentParser(description="Explicit recovery contracts for agent actions")
from . import __version__
parser.add_argument("--version", action="version", version="CommitLatch " + __version__)
commands = parser.add_subparsers(dest="command", required=True)
commands = parser.add_subparsers(dest="command", required=True,
metavar="{demo,http-demo,inspect,replay,reconcile-demo}")
demo = commands.add_parser("demo", help="Run three real process-crash scenarios with test data")
demo.add_argument("--directory", help="New or empty output directory")
http_demo = commands.add_parser("http-demo", help="Compare recovery over loopback HTTP with a dropped response")
Expand All @@ -27,7 +28,7 @@ def main(argv=None):
if name == "reconcile-demo":
command.add_argument("--provider-db", required=True)
command.add_argument("--opaque", action="store_true")
internal = commands.add_parser("_worker", help=argparse.SUPPRESS)
internal = commands.add_parser("_worker")
internal.add_argument("directory")
internal.add_argument("scenario", choices=("naive", "reconciled", "opaque"))
args = parser.parse_args(argv)
Expand Down
13 changes: 13 additions & 0 deletions tests/test_http_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import io
import json
import tempfile
import unittest
from concurrent.futures import ThreadPoolExecutor
from contextlib import redirect_stdout
from http.client import HTTPException
from pathlib import Path
from urllib.error import HTTPError, URLError

from commitlatch.cli import main
from commitlatch.http_demo import DemoHTTPAdapter, HTTPFixture, run_http_demo


Expand Down Expand Up @@ -65,5 +68,15 @@ def send(_):
self.assertEqual(provider.snapshot()["native_replays"], 5)


class CLIHelpTests(unittest.TestCase):
def test_help_hides_internal_worker(self):
output = io.StringIO()
with redirect_stdout(output), self.assertRaises(SystemExit):
main(["--help"])
self.assertIn("http-demo", output.getvalue())
self.assertNotIn("_worker", output.getvalue())
self.assertNotIn("==SUPPRESS==", output.getvalue())


if __name__ == "__main__":
unittest.main()