fix(config): always use global timezone instead of hidden profile value (#9706) - #9836
Open
aniruddhaadak80 wants to merge 2 commits into
Open
fix(config): always use global timezone instead of hidden profile value (#9706)#9836aniruddhaadak80 wants to merge 2 commits into
aniruddhaadak80 wants to merge 2 commits into
Conversation
…ike fallback (AstrBotDevs#9788) In the skills_like tool requery fallback path, the runner yielded llm_result (sending the response to the user) before calling _complete_with_assistant_response, which triggers on_agent_done hooks. Plugins doing content safety review, sanitization, or rewriting could not affect text already sent. Moved the completion call before the yields.
…ue (AstrBotDevs#9706) Chat profiles can contain a hidden timezone field that is not exposed in the profile WebUI schema. This silently overrides the global timezone setting, leaving users unable to discover or change the effective timezone. Always read timezone from the global config to ensure consistent behavior.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Chat profiles can contain a hidden
timezonefield that is not exposed in the profile WebUI schema. This silently overrides the global timezone setting, leaving users unable to discover or change the effective timezone.Why This Change Was Made
The runtime at
astr_main_agent.py:1060-1062readsconfig.timezone(profile) first, falling back to the global config only when it'sNone. Since the profile schema doesn't expose timezone in the WebUI, users cannot see or modify this hidden value. A profile created with an old timezone will continue to override the global setting indefinitely.User Impact
Timezone is now always read from the global config, ensuring consistent behavior across all profiles. Users who set the global timezone in Settings will see it applied everywhere.
Evidence
astr_main_agent.py:1060-1062— profile timezone shadows globalCONFIG_METADATA_3) excludes timezone while system schema (CONFIG_METADATA_3_SYSTEM) includes itplugin_context.get_config().get("timezone"))Summary by Sourcery
Use the global timezone consistently and complete assistant response processing before returning final LLM results.
Bug Fixes: