fix: skip queued LLM requests after disabling - #9843
Open
kidding-404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
LLM availability was previously checked before entering the internal agent stage. A request that passed this check could wait for the session lock while an administrator disabled LLM access.
After acquiring the lock, the queued request continued without checking the latest state, which could cause delayed replies after LLM access had already been disabled.
This change performs a second authoritative check immediately before building and dispatching the agent request.
Fixes #9819.
Testing
uv run ruff format .uv run ruff check .uv run pytest tests/unit/test_session_lock.py -quv run pytest tests/unit/test_session_management_service.py -quv run pytest tests/test_conversation_checkpoint.py -qSummary by Sourcery
Recheck LLM availability after queued requests acquire the session lock to prevent processing after access has been disabled.
Bug Fixes:
Tests: