fix: keep system reminders out of conversation history - #9844
Open
kidding-404 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the temporary marker is wrong, system reminders will be omitted from saved conversation history, so reconstructed conversations could lack that context. Reverting restores persistence for future messages but cannot recover reminders that were already skipped, although the reminders are derived and the impact is bounded.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark injected system reminders as temporary content. The reminders remain available to the model for the current request but are excluded from persisted conversation history, preventing them from polluting later context and repeatedly consuming tokens.
The existing main-agent test is extended to cover both the current-request and persistence behavior.
Testing
uv run ruff format .uv run ruff check .uv run pytest tests/unit/test_astr_main_agent.pyFixes #9779
Summary by Sourcery
Prevent system reminders from polluting future conversation context and consuming tokens repeatedly.
Bug Fixes:
Tests: