fix: bridge unsigned Gemini 3 tool histories - #9853
Open
SunmiJJW wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4359c44258
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini 3 requires a thought signature when function-call history is replayed. AstrBot preserves genuine Gemini signatures, but a tool call produced by another provider has no Google-specific metadata, so switching or falling back to Gemini 3 can fail with a 4xx validation error.
Google documents
skip_thought_signature_validatorfor the unavoidable cross-model-history case: https://ai.google.dev/gemini-api/docs/generate-content/thought-signaturesModifications / 改动点
Verification Steps / 验证步骤
Test Results / 运行结果
9 passedChecklist / 检查清单
Summary by Sourcery
Support replaying unsigned cross-provider tool histories with Gemini 3 without changing existing Gemini 2.5 or non-Gemini behavior.
Bug Fixes:
Tests: