Skip to content

feat: update contact form to use npm package - #698

Merged
mathiazom merged 49 commits into
mainfrom
feat/update-contact-form-to-use-npm-package
Sep 14, 2026
Merged

mathiazom merged 49 commits into
mainfrom
feat/update-contact-form-to-use-npm-package

Conversation

@sifterstudios

Copy link
Copy Markdown
Collaborator
image

this PR transfers the contact-form from being embedded in planner-web to being imported from @mrfylke/contact-form. Has been tested locally, looks to have identical functionality.

Would appreciate some new eyes on this and advice on testing the submit call with e2e testing.

@vercel

vercel Bot commented Feb 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
planner-web Ready Ready Preview Sep 14, 2026 12:26pm UTC

Request Review

@rosvik

rosvik commented Feb 23, 2026

Copy link
Copy Markdown
Member

Hey, nice to have you here @sifterstudios! Deleting 11k lines of code is certainly one way to make an entrance 🔥

Is the source code of @mrfylke/contact-form made public anywhere? Should it be?

@sifterstudios

Copy link
Copy Markdown
Collaborator Author

Hey, nice to have you here @sifterstudios! Deleting 11k lines of code is certainly one way to make an entrance 🔥

Is the source code of @mrfylke/contact-form made public anywhere? Should it be?

Hello, hello! 🔥🌪️
Yes, moving source code into npm packages is a great way of deleting code lines 😅!

@mrfylke/contact-form will be moved into a repo here at @atb-as to simplify deployment. There's no need for it to be private, as it's original code from planner-web, and the npm package is public with the same EUPL 1.2 license. 😄

@sifterstudios

Copy link
Copy Markdown
Collaborator Author

Update @rosvik - repo moved here: https://github.com/atb-AS/mrfylke-contact-form

@rosvik rosvik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look through this now with @strandlie, and I think it makes sense overall 👍 A couple of questions:

  • Theme and language doesn't seem to be synced between contact form and the main application. Could we use the same cookie for both?
  • Comments 👇

Comment thread package.json Outdated
Comment thread src/config/contact-form-config.tsx Outdated

@rosvik rosvik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sifterstudios If you don't have the time to look into the comments, I think this is a nice change as is ✨ (Or, shout if you disagree, @strandlie 👀)

I fixed the merge conflicts now - is there anything else blocking us from merging? Do you have time to test it for FRAM in the near future?

@rosvik

rosvik commented Jun 17, 2026

Copy link
Copy Markdown
Member

@rosvik
rosvik marked this pull request as draft June 17, 2026 12:31
@mathiazom
mathiazom force-pushed the feat/update-contact-form-to-use-npm-package branch from 35ba029 to f64306f Compare August 28, 2026 12:44
@mathiazom mathiazom self-assigned this Aug 28, 2026
@mathiazom
mathiazom force-pushed the feat/update-contact-form-to-use-npm-package branch from f64306f to 2d9835e Compare August 28, 2026 12:55
@mathiazom
mathiazom marked this pull request as ready for review August 31, 2026 09:39
@mathiazom
mathiazom requested a review from gorandalum as a code owner August 31, 2026 09:39
@mathiazom
mathiazom marked this pull request as draft August 31, 2026 09:43
@mathiazom
mathiazom force-pushed the feat/update-contact-form-to-use-npm-package branch from a496651 to 76db49a Compare September 2, 2026 07:23
@mathiazom
mathiazom force-pushed the feat/update-contact-form-to-use-npm-package branch from 76db49a to 5f434af Compare September 8, 2026 13:05
@mathiazom
mathiazom force-pushed the feat/update-contact-form-to-use-npm-package branch from f64847f to 26753d4 Compare September 14, 2026 11:52

@rosvik rosvik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Works well locally

Comment thread src/translations/language-context.tsx Outdated
Comment thread pnpm-workspace.yaml Outdated
Co-authored-by: Johannes Røsvik <j.rosvik@gmail.com>
@mathiazom
mathiazom merged commit 215f1a7 into main Sep 14, 2026
3 checks passed
@mathiazom
mathiazom deleted the feat/update-contact-form-to-use-npm-package branch September 14, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants