Repository navigation
Fix bidirectional BFS path reconstruction for empty and meeting paths - #1486
Open
huxiaoyi-ovo wants to merge 2 commits into
Open
huxiaoyi-ovo wants to merge 2 commits into
huxiaoyi-ovo wants to merge 2 commits into
Conversation
huxiaoyi-ovo
marked this pull request as ready for review
October 29, 2026 09:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bidirectional breadth-first planner reconstructs paths from both search trees, but three cases are mishandled:
None, yet reconstruction is still attempted, raising an exception instead of returning an empty path.closed_set[-1]for the root node, raisingKeyError.Fix
Reconstruct each half directly using its existing
parentpointers. Return([], [])when no meeting point was found, and include the shared meeting waypoint only once. The search order, collision checks, grid representation, and publicplanning()signature remain unchanged.Regression tests
A new test module covers:
Two files changed. No new dependencies.
Cross-platform CI validation is running on the fork.
AI disclosure: ChatGPT assisted with code analysis, the fix, and regression tests.