Repository navigation
Conversation
yunyv
marked this pull request as ready for review
November 3, 2026 12:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
No matching issue or competing fix found for Inverter's handling of a running child.
What does this implement/fix?
InverterNodedocuments that it passes throughRUNNING, but currently converts it toFAILURE. For example, a tree built from<Inverter><Sleep sec="1.5" /></Inverter>immediately reports failure while its child is still running.Preserve
RUNNINGwithout changing the existing success/failure inversion. Add a three-state regression and an XML-factory test that advances a controlled clock through the child's completion. No actual sleeps, API, parameter, dependency, or CI changes.Additional information
Prepared and tested with AI assistance; no human review or hardware verification is claimed.
Linux / Python 3.13.5 and 3.14.8, pytest 9.1.0, Ruff 0.17.1:
git diff --check: passed. Ruff reports an existing configuration deprecation warning.The configured mypy package list does not include MissionPlanning. Full
bash runtests.sh, documentation build, animations and other platforms were not run; the full suite includes an unrelated PlantUML network/plotting test. The existing Inverter docstring and official RST autodoc already describe the correct behavior.CheckList
9e73a85ce28c698c470d75551922d41e501a1740on Windows/Python 3.13 and reports 160 passed in 366.91s (https://ci.appveyor.com/project/AtsushiSakai/pythonrobotics/builds/55007246). GitHub Actions Linux_CI, Windows_CI, MacOS_CI and CodeQL have not run: all four await maintainer approval. This checklist remains unchecked until those workflows complete. The local-test limitations above still apply.