Repository navigation
Clarify mapping keys and remove stale comments - #1161
Merged
Merged
Conversation
KillariDev
enabled auto-merge
October 13, 2026 23:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the meaning and order of unnamed Solidity mapping keys and values, including ERC-1155 balances and approvals, share migration accounting, escrow outcomes, approval nonces, factory deployment IDs, and auction/carry-tree indexes. Distinguish one-based Fenwick indexes from zero-based MMR leaf indexes and specify accounting units where needed.
Remove stale or redundant procedural comments and a commented-out escalation migration call. Clarify underfunded auction estimates, attoETH units, and the rationale for broad live-network price-test bounds.
All source and test edits are comments only. Refresh the comment-sensitive documentation audit fingerprints and regenerate the reference pages' hidden fingerprint comments. Executable behavior, assertions, compiled ABIs, storage declarations, license headers, compiler directives, and rendered documentation are unchanged.
Validation:
bun run tscbun ./tooling/testing/bun-test.mts tooling/docs/contract-reference-metadata.test.ts(5 tests)bun run format:checkbun run checkbun run knipbun run check:generated-cleangit diff --checkProtocol, application, and browser tests are skipped because executable behavior, assertions, and interfaces are unchanged. Browser QA and visual review are skipped because no rendered appearance or interaction changes. The affected metadata tests and documentation freshness check cover the audit-pin updates; documentation review covers the generated HTML comments.