Repository navigation
Fix the remaining UI/UX audit findings across Zoltar, Statoblast, Trading, and augurScan - #1165
Open
KillariDev wants to merge 1 commit into
Open
KillariDev wants to merge 1 commit into
KillariDev wants to merge 1 commit into
Conversation
…ding, and augurScan A UI/UX audit of the three apps, their shared UI, and the augurScan explorer reported 93 findings; #1154 and #1162 already fixed 3 of them and one was invalid. This fixes the rest, or the safest part of a finding where the full change needs a design decision. Statoblast: a blank initial report price no longer submits the stale cached price, and commitment and withdrawal checks run at the price that will be proposed. Claimable fees read the checkpointed amount that redeemFees pays. Pool creation targets the active universe. Reporting from vault REP offers only what the contract accepts. Migration actions close with the migration window, vaults beyond the 50-vault preview can be liquidated, and truth-auction estimates and totals use previewFinalization. Browse pools discovers pools from the factory. Vault approvals and WETH wrapping appear inline before Review, the reporting approval uses TokenApprovalControl, and disputes get a Wrap ETH step. Unreachable vault-action code is deleted. Zoltar: a partial scalar migration is no longer reported as complete. Question creation rejects Yes/No categorical outcomes, Invalid, case-insensitive duplicates, and existing questions. Use for fork stays disabled until a question ends, and the choice persists in the URL. The fork page shows the REP credited to the migration balance. Migrate REP is its own persistent button. Trading: a sale never signs more shares than entered, and the ticket shows the maximum sold. Capacity and price-impact limits state the largest accepted amount. The ticket and liquidity panel wait for post-receipt balances. Markets load from the registry, prices say they are conditional on a valid resolution, resolved markets show their outcome, Max is exact, and liquidity keeps ETH for gas. augurScan: live refreshes preserve filters, open details, and focus. Deep-linked logs are revealed, pinned, and closable. History restores rich list state, network changes drop block numbers, and CSV exports raw values. The activity feed is labelled and no longer scrolls sideways at medium widths. Shared: the app chrome is a header landmark, and the loading placeholder and startup error share the app frame. Focus rings are stronger. Disabled controls keep focus and give reasons, a missing wallet is explained instead of offering an impossible connect, and RPC errors read as plain language. The tutorials, screenshots, screenshot specs, and browser workflow helpers follow the new labels and inline approval flow.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A UI/UX audit of Zoltar, Statoblast, Trading, the shared UI, and the augurScan explorer reported 93 findings. #1154 and #1162 already fixed three of them, and one was invalid. This change fixes the rest. Where the full fix needs a design decision, it lands the safest part and lists what remains. Several High findings could send transactions that were certain to revert or misstate funds; those are fixed with failing-first regression tests.
Statoblast
redeemFeespays:updateVaultFeesandsecurityVaultsgo into one Multicall3aggregate3. Before, a passive vault showed 0 and "Claim fees" stayed disabled.depositToEscalationGameaccepts: coverage plus the minimum remaining deposit.previewFinalization(), so they match what finalization pays.TokenApprovalControl. Disputes get a Wrap ETH step.ui/AGENTS.mdnow points at the live "Funding and approvals" flow.Zoltar
Trading
maxLongSharesIn, which was sized as the entered amount plus slippage. The ticket now shows a "Maximum sold" row.augurScan
Shared
<header>landmark and only route content is in<main>. The static loading placeholder and the startup error notice share the app frame, so neither leaves "Loading…" behind.Screenshots
Headless Chromium against the walletless simulation, at the exact viewport noted.
The tutorial screenshots for all three apps are recaptured, and the pages that quote changed labels are updated.
Not done, or done differently
check-unit-terminologyforbids wei/gwei; the unit stays "nanoETH per gas". The create-pool fee now shows two decimals.ActionAvailabilitytype change;Validation
bun run ui:build:apps,bun run tsc,bun run format:check,bun run knip,bun run check:changed,bun run check:repository:current,bun run docs:check,bun run check:static,git diff --check: pass.bun run checkpasses excepttest:preflight'stooling/repo/project-registry.integration.test.ts. That test requires the pinned Bun 1.4.2, and the local machine has 1.4.3; the other preflight tests pass when run on their own.ui/coreShared,ui/zoltar,ui/statoblast,ui/trading): 4015 pass, 0 fail, including the Anvil integration tests.bun run test:browser:smoke: pass.test:browser:workflow: 6/6 pass. Its helpers now approve inline before Review and read the shared approval control's label.bun run docs:screenshotsfor all apps: freshness check clean, search index rebuilt.main.