Add .NET 10 target framework. - #202
Open
tylerwarner33 wants to merge 3 commits into
Open
tylerwarner33 wants to merge 3 commits into
tylerwarner33 wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-targets
Autodesk.Forge.CoreandAutodesk.Forge.Core.E2eTestHelperstonet8.0;net10.0, so each package ships a native .NET 10 asset next to the existing .NET 8 asset.net8.0stays and is listed first, so this is not a breaking change for any existing consumer.Why now
.NET 8 and .NET 9 both leave support on 10 November 2026. .NET 10 is LTS until 14 November 2028.
Autodesk.Forge.Coreis the base of the APS SDK for .NET (Autodesk.SDKManagerreferences it). The APS SDK is addingnet10.0in autodesk-platform-services/aps-sdk-net#260, but itsnet10.0builds use thenet8.0assembly of this package until this package has anet10.0asset.net9.0is skipped deliberately. It is an STS release that leaves support on the same day as .NET 8.Changes
Directory.Build.props:<TargetFramework>net8.0</TargetFramework>becomes<TargetFrameworks>net8.0;net10.0</TargetFrameworks>. All 3 projects get it from this file..github/workflows/dotnet-core.yml:setup-dotnetinstalls8.0.xand10.0.x. SDK 8 cannot buildnet10.0(NETSDK1045), so without this change the PR check fails.README.md: the framework badge and the requirements line state .NET 8 and .NET 10.No dependency version changes. The current test tools (
Microsoft.NET.Test.Sdk17.12.0,xunit2.9.2,xunit.runner.visualstudio2.8.2) work onnet10.0.Microsoft.Extensions.*9.0.0 works onnet10.0through itsnet9.0asset.Verification
dotnet build Autodesk.Forge.sln -c Release: 0 errors. The only warning is the existing CS0618 inTestForgeConfiguration.cs:41, now once for each framework.dotnet test: 38 of 38 pass onnet8.0, and 38 of 38 pass onnet10.0.lib/net8.0/andlib/net10.0/, with a dependency group for each.lib/net8.0on .NET 8 and .NET 9, andlib/net10.0on .NET 10. It runs on .NET 8 and .NET 10.Release note for maintainers
This PR does not change
<Version>(still 4.1.2). The Publish step indotnet-core.ymlruns on each push tomain, so a version change here could publish an unsigned package before the signed release process from #201. Adding a framework is additive, so SemVer suggests 4.2.0. Suggested CHANGELOG entry:Please note these items, which I found while testing:
403 (The specified API key is invalid, has expired, or does not have permission to access the specified package.). That is why 4.1.2 is not on nuget.org. TheNUGETAPIKEYBYENGOPSsecret needs a new key before any release.dotnet-core.ymlhides failures.src/Directory.Build.targetssetsIgnoreExitCodeandContinueOnErrorondotnet nuget push, so that run reported success.Microsoft.Extensions.*10.0.x, andactions/setup-dotnet@v5(the v4 action now runs with a Node.js 20 deprecation warning).🤖 Generated with Claude Code