Improve native SQL and WordPress workload compatibility - #393
Merged
Conversation
# Conflicts: # inc/native/class-wp-markdown-native-query-executor.php
chubes4
marked this pull request as ready for review
September 10, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incremental native SQL and WordPress compatibility improvements for #377. This PR does not complete MySQL parity or close that tracker.
Verification
Exact tested head:
8e49a8a66db2806045e51ecc3d09f905a5602fa0, including current mainaa184caand local scalar UPDATE repair8f50078.Unmodified consumer acceptance, WordPress 7.1 / PHP 8.3, managed multisite PHPUnit and shared WP-CLI harness, explicit native candidate source, without diagnostic preload:
JUnit identity comparison against
6b10e4aconfirms the scheduled fanout parent-completion failure is fixed, with no new failures. Real AI parking/resume and scheduled child fanout workflows now both pass.Targeted repo-native regression commands:
Persisted-state tests cover eligible versus active leases, left-to-right assignments, replay rejection, AND/OR precedence, unknown columns, later-row validation failure without partial writes, unique-key rejection, rollback, and integers above floating-point exact precision.
Operator-retained acceptance run names:
scalar-update-ticket-native-8e49a8a,scalar-update-full-native-8e49a8a, andscalar-update-full-mysql-control. Each retains the effective recipe, source revision, structured test results and full PHPUnit JUnit XML. These are local operator artifacts, not publicly hosted evidence; the commands above reproduce the owning-layer regressions from this repository.Remaining Scope
The 19 remaining consumer failures retain their previous identities: four physical-mysqli requirements and fifteen engine-gated identity/upsert outcomes. No fake InnoDB label or weakened consumer assertion is introduced. Native does not provide physical mysqli sessions or full InnoDB/MVCC semantics. Scalar aggregate support, SQL modes, numeric coercion/overflow, temporary session lifetime, and other SQL families remain bounded rather than complete MySQL compatibility.
No release or deployment is part of this merge. Performance work remains deferred.
AI Assistance
OpenAI GPT-6 Astra (
openai/gpt-6-astra) via OpenCode implemented and reconciled the latest SQL repairs, reviewed local changes, ran regressions and remote native/MySQL acceptance, compared JUnit failure identities, and prepared this merge at the maintainer's direction. Earlier work in this branch also used OpenAI GPT-5.6 Terra via OpenCode.