Repository navigation
[AI Summaries] Remove AI summaries - #6147
Conversation
|
Claude finished @sztomek's task in 1m 2s —— View job This looks good to merge and I found nothing blocking. Generated chapters still get fetched on both screens. |
Generated by 🚫 Danger |
bb0d5ff to
7a9d2d6
Compare
|
Claude finished @sztomek's task in 1m 8s —— View job This looks good to merge and I found nothing blocking. Episode details is back to the production layout, the player has no Summary tab, and generated chapters are still fetched once per episode from Non-blocking
|
| viewModelScope.launch(ioDispatcher) { | ||
| mode.episodeIdFlow() | ||
| .filter { it.isNotEmpty() } | ||
| .collectLatest(transcriptManager::loadGeneratedChapters) |
There was a problem hiding this comment.
(non-blocking) If the -meta.json request fails once, for example when playback starts offline, the player won't show generated chapters for that episode until a different episode plays. On main this only kept working by accident: SummaryViewModel stayed NotAvailable when summaries were off, so every listDataLive emission fetched again. Now loadGeneratedChapters runs once per episodeUuid and swallows the error. If that matters, retry on failure, e.g. have it return a success flag and retry with backoff, or re-trigger it on a connectivity change. Otherwise it's fine to accept and leave as is.
|
Claude finished @sztomek's task in 29s —— View job I found nothing new since the last review, and the one open finding is resolved. |
|
Version |
8bf5e04 to
9cb4e95
Compare
|
Claude finished @sztomek's task in 27s —— View job Nothing new since the last review, and nothing is still open. This push rebases the same 8 commits onto the latest |
Description
Removes AI summaries completely. The
AI_SUMMARIESflag was never turned on in production, so production users keep exactly what they see today. Plus, product team decided to mold summaries into Episode chat so the feature become unnecessary.Generated chapters keep working, now without summaries
TranscriptManager.loadSummaryText()was the only code that fetched<transcript>-meta.json, which is also how generated chapters get saved.loadGeneratedChapters(), which only depends onGENERATED_CHAPTERS.ChaptersViewModelcalls it for its episode. That covers both the player and Episode details, since both screens share that view model with their Chapters tab.Player
SummaryFragment,SummaryViewModeland the summary analytics event.Episode details
EPISODE_CHATis on), as in production today. [Episode Chat] Remove the chat entry from Episode details #6146 removes it separately.fragment_episode.xmllayouts are back to their pre-Redesign episode details screen with AI summaries #5353 version. The only difference is that the show notes start visible, as they do in production.Also removed
Feature.AI_SUMMARIESandOnboardingUpgradeSource.AI_SUMMARIES.SummaryPaywall,SummaryContentandMarkdownUtils.showCloseButtonoption that Redesign episode details screen with AI summaries #5353 added to the transcript toolbar.episode_summary,summary_upsell_title,summary_upsell_description,summary,player_tab_summary, and the already unuseddescription), fromvalues/and all 16 translations.Visible change in debug and prototype builds
Testing Instructions
Use a debug build with "Generated chapters" on in Beta features.
…-meta.jsonrequest.Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...