Skip to content

one snackbar list, css transitions for the drawer - #3844

Merged
pfefferle merged 1 commit into
trunkfrom
fix/layout-shell-duplicates
Sep 29, 2026
Merged

pfefferle merged 1 commit into
trunkfrom
fix/layout-shell-duplicates

Conversation

@pfefferle

Copy link
Copy Markdown
Member

Proposed changes:

Two things that came out of looking at our Layout next to boot's shell.

  • Toasts showed twice. Boot's root already renders the snackbar notices from core/notices, and our Layout rendered a second list for the same notices. Ours is gone.
  • The mobile sidebar drawer and its backdrop were animated with __unstableMotion and __unstableAnimatePresence from @wordpress/components. They are CSS transitions now, with prefers-reduced-motion respected through the base-styles mixin. Same 0.2s fade and slide as before.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Open the Social Web screen, follow or block someone from the followers actions (or trigger any snackbar). One toast, not two.
  • Narrow the window below 782px, open the menu with the header button: the drawer slides in and the backdrop fades. Close it via the backdrop or Escape: it slides out. With "reduce motion" enabled in the OS, both switch without animation.

@pfefferle pfefferle added the Bug Something isn't working label Sep 29, 2026
@pfefferle pfefferle self-assigned this Sep 29, 2026
@pfefferle
pfefferle requested a review from a team September 29, 2026 15:05
@github-actions github-actions Bot added [Feature] Reader [Focus] Editor Changes to the ActivityPub experience in the block editor labels Sep 29, 2026
@pfefferle
pfefferle force-pushed the fix/layout-shell-duplicates branch from 8a1cd24 to 38aea66 Compare September 29, 2026 15:38
@pfefferle
pfefferle merged commit 7e7ae88 into trunk Sep 29, 2026
6 checks passed
@pfefferle
pfefferle deleted the fix/layout-shell-duplicates branch September 29, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working [Feature] Reader [Focus] Editor Changes to the ActivityPub experience in the block editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant