use core's design tokens - #3846
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
The app referenced 18 different
--wpds-*custom properties, and 16 of them do not exist in core'sdesign-tokens.css, so everyvar( --wpds-…, fallback )silently used its fallback and nothing followed the admin theme. This maps them to the tokens core defines:dimension-padding/gap/size,typography-font-size/line-height/font-weight,border-width. Fallbacks stay, so the default theme renders the same, with three exceptions that snap to core's scale: two 16px texts become 15px, one 14px text 13px, and the sidebar focus rings go from 1.5px to core's 2px.Values core has no token for (6px, 20px margin, 48px avatar, 64px site icon, weight 500) are plain values now instead of pretending to be tokens.
Other information:
Testing instructions:
data-wpds-corner-radius="pronounced"on<html>: cards and inspector follow the radius variant.