Skip to content

use core's design tokens - #3846

Merged
pfefferle merged 1 commit into
trunkfrom
update/design-tokens
Sep 30, 2026
Merged

pfefferle merged 1 commit into
trunkfrom
update/design-tokens

Conversation

@pfefferle

Copy link
Copy Markdown
Member

Proposed changes:

The app referenced 18 different --wpds-* custom properties, and 16 of them do not exist in core's design-tokens.css, so every var( --wpds-…, fallback ) silently used its fallback and nothing followed the admin theme. This maps them to the tokens core defines: dimension-padding/gap/size, typography-font-size/line-height/font-weight, border-width. Fallbacks stay, so the default theme renders the same, with three exceptions that snap to core's scale: two 16px texts become 15px, one 14px text 13px, and the sidebar focus rings go from 1.5px to core's 2px.

Values core has no token for (6px, 20px margin, 48px avatar, 64px site icon, weight 500) are plain values now instead of pretending to be tokens.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Open the Social Web screen: it should look as before. Tab through the sidebar: focus rings are 2px.
  • In dev tools, set data-wpds-corner-radius="pronounced" on <html>: cards and inspector follow the radius variant.

@pfefferle pfefferle added Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. Code Quality labels Sep 29, 2026
@pfefferle pfefferle self-assigned this Sep 29, 2026
@pfefferle
pfefferle requested a review from a team September 29, 2026 15:52
@github-actions github-actions Bot added [Feature] Reader [Focus] Editor Changes to the ActivityPub experience in the block editor labels Sep 29, 2026
@pfefferle
pfefferle merged commit 29f62b9 into trunk Sep 30, 2026
8 of 9 checks passed
@pfefferle
pfefferle deleted the update/design-tokens branch September 30, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Quality [Feature] Reader [Focus] Editor Changes to the ActivityPub experience in the block editor Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant