Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spike for the two "Watch" items about our own shell: boot's full-page mode instead of our Layout. Not meant to merge; it is here to look at and decide.
What it does
loader.tscalls boot'sinit()instead ofinitSinglePage(), withmenuItemsanddashboardLinkfrom PHP (class-app.php, newactivitypub_app_menu_itemsfilter), plus an init module (src/app/init.ts) that sets the menu icon (postListfrom@wordpress/icons) the way boot documents it.Layout,SidebarandSiteHubcomponents are deleted (919 lines): boot draws the sidebar, the dashboard back button, the surfaces and the mobile drawer. The feed renders straight into boot's stage column.components/feed-header); the type and tag shortcuts become primary DataViews filters (isPrimary: true), shown next to the search at all times with their options and an "Any" default. The date filter is behind the bar's "Add filter" button.style.scssis gone too; boot lays out stage and inspector on its own 8px grid.Not attempted: generating the PHP with
@wordpress/build(CMF-630). That only makes sense if this shell is wanted, and it would turn this into a build-tooling change on top of a UX change.Findings
SidebarToggleFill(from@wordpress/admin-ui'sPage). That slot lives inside boot's bundled copy of admin-ui, which core does not ship to plugins, so our stage cannot render the toggle and the drawer can never open. No back button either. This is a blocker as long as admin-ui is not exposed.Item, whosepath { fill: currentColor }turns the stroke-based icons of@wordpress/icons17 into solid boxes. Components 40.1.0 dropped that rule (gutenberg#78808), but WordPress 7.1.x still ships the olderwp-components, and boot uses core's copy at runtime. The spike scopes afill: noneoverride to.boot-navigation-itemwith a comment to remove it once the minimum WordPress version carries the fix.FiltersToggleisdisabledwhen any filter is primary); adding the date filter moves to the "Add filter" button inside the bar.Store "activitypub/app" is already registeredin the console. Both the route and the content bundle register the app store (also on trunk). Worth its own fix.Testing
ap_object_typeandap_tagterms assigned to the test posts so the filters have options.